Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When proctoring is enabled, hide the back button in secure layout #39

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

rohansharmasitoula
Copy link
Contributor

@rohansharmasitoula rohansharmasitoula commented Dec 8, 2023

Description

  • When proctoring is enabled, hide the back button

Github Issue

Checklist before requesting a review

  • One line description of the changes is added in the PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires only a documentation update

Summary by CodeRabbit

  • New Features

    • Implemented a new visual behavior on the secure page layout to enhance user experience.
  • Documentation

    • Updated version and release notes to reflect the latest incremental update.
  • Bug Fixes

    • Addressed minor issues for improved stability and performance.

Copy link

coderabbitai bot commented Dec 8, 2023

Walkthrough

The changes involve an update to a Moodle plugin, where a JavaScript snippet has been added to hide a back button when proctoring is enabled, and the version information of the plugin has been updated to reflect a new build and release.

Changes

File Summary of Changes
rule.php JavaScript snippet added to setup_attempt_page function to hide back button under certain conditions.
version.php Updated version and release information of the plugin.

Assessment against linked issues

Objective Addressed Explanation
#38: Hide the back button when proctoring is enabled The JavaScript snippet in rule.php is designed to hide the back button, addressing the issue directly.

Poem

In the code where features weave,
A back button takes its leave.
With proctor's gaze, so stern and strict,
Our rabbit's code makes the fix so slick. 🐇✨


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 15be0c9 and 0389c35.
Files selected for processing (2)
  • rule.php (1 hunks)
  • version.php (1 hunks)
Files skipped from review due to trivial changes (1)
  • version.php
Additional comments: 1
rule.php (1)
  • 250-260: The JavaScript snippet correctly targets the back button and hides it when proctoring is enabled, aligning with the PR objective to enhance the user experience for proctored exams by preventing accidental navigation away from the quiz page.

@rohansharmasitoula rohansharmasitoula changed the base branch from master to release/v1.3.1 December 8, 2023 11:06
@rakeshprabhu rakeshprabhu changed the title When proctoring is enabled, hide the back button When proctoring is enabled, hide the back button in secure layout Dec 8, 2023
@rakeshprabhu rakeshprabhu merged commit b042df4 into release/v1.3.1 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When proctoring is enabled, hide the back button
2 participants