Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regressions triggered by (c)ontinue calls during a session #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CodeGuro
Copy link

@CodeGuro CodeGuro commented Sep 6, 2020

There were also a couple other issues...
First and foremost, this resolves the regression described in issue #29 caused by commit 18cd5a4. We want to allow the debugger to continue, but we don't want to close the connection on the socket until it's actually time to shut down (EOF or SIGQUIT or an exception occurs etc).

Secondly, the replacement of the sys.stdin and sys.stdout as file objects is not enough - we want to update the underlying file descriptor because there may be some other underlying object that saved/uses the old stdin/stdout. As such, to we use dup2 to ensure subsequent reads/writes go into the socket. Though honestly, it's a bit redundant because the PDB/BDB class inherits the Cmd class which reads from the socket implicitly anyway (passing the socket handle as stdin/stdout is sufficient).

Anyway, this should at least make it functional again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant