Add build-system table to pyproject.toml #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pip>=19 installation, which will use the PEP-517 build-system if a pyproject.toml file exists. Without this table, installation will fail because the default used (when the table is absent) is setuptools, but we use poetry.
|
Thank you for the pull request, @danmactough . I will draft a release around today. |
|
Happy to help. Thank you for the great package @tammoippen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of our builds that depend on this project started to fail today. I was able to track down the root cause of the failure was that pip v19 was released yesterday, and the new version includes PEP-517 support for projects containing a
pyproject.tomlfile. https://github.com/pypa/pip/pull/6155/files#diff-ef9433b15a3e8fc5d09dda210feca0c4R26Without the
build-systemtable added by this PR, installation with pip >= 19 will fail because the default used when the table is absent issetuptools, but we usepoetry. Conveniently, the poetry docs explain exactly how to update our pyproject.toml to comply with PEP-517 builds:https://poetry.eustace.io/docs/pyproject/#poetry-and-pep-517