Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add mysql-connector instrumentor support for sqlcommenting #8

Closed

Conversation

tammy-baylis-swi
Copy link
Owner

@tammy-baylis-swi tammy-baylis-swi commented Oct 17, 2024

Description

Updates mysql-connector instrumentor to support sqlcommenting.

Depends on # 2897

Fixes # 2902

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added unit tests. Used local installations of opentelemetry-instrumentation-dbapi (in #open-telemetry#2897) and upstream dependencies with this updated downstream instrumentor on a Flask app that use mysql-connector to query MySQL with general logs enabled to check sqlcomments.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@tammy-baylis-swi tammy-baylis-swi changed the title Add mysql-connector sqlcomment support [WIP] Add mysql-connecotr instrumentor support for sqlcommenting Oct 17, 2024
@tammy-baylis-swi tammy-baylis-swi changed the title [WIP] Add mysql-connecotr instrumentor support for sqlcommenting [WIP] Add mysql-connector instrumentor support for sqlcommenting Oct 17, 2024
@tammy-baylis-swi
Copy link
Owner Author

Replaced by open-telemetry#2943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant