Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themed / Monochrome launcher app icon support #56

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

sebastien46
Copy link

Closes #55

@@ -2,4 +2,5 @@
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
<background android:drawable="@drawable/ic_launcher_background"/>
<foreground android:drawable="@drawable/ic_launcher_foreground"/>
<monochrome android:drawable="@drawable/ic_launcher_monochrome"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we just use ic_launcher_foreground?

Copy link
Author

@sebastien46 sebastien46 Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we just use ic_launcher_foreground?

Unfortunately not, as it only comprises of the center circle, not the line across (which is in ic_launcher_background), unless that's what you want:

ic_launcher_foreground

Also, the fill needs to be one color only, as it appears as a fully white vector to the launcher

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't think mean that the icons won't actually match? What does that new icon look like side by side with the old?

Copy link
Author

@sebastien46 sebastien46 Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't think mean that the icons won't actually match? What does that new icon look like side by side with the old?

Old vs New vs New (Night Mode) Square (Yellow Theme):

image
image
image

Old vs New vs New (Night Mode) Circle (Yellow Theme):

image
image
image

It pretty much works with any color.

@tananaev tananaev merged commit f300958 into tananaev:master Dec 5, 2023
1 check passed
@tananaev
Copy link
Owner

tananaev commented Dec 5, 2023

Looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Themed / Monochrome launcher app icon support
2 participants