Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [min|max]_duration restriction in combination with PARKING_TIME #53

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Fix [min|max]_duration restriction in combination with PARKING_TIME #53

merged 2 commits into from
Jul 5, 2023

Conversation

remkop22
Copy link
Contributor

@remkop22 remkop22 commented Jul 5, 2023

min_duration and max_duration should be compared against the actual session time, not charging time.

@remkop22 remkop22 requested a review from rudolphfroger July 5, 2023 10:05
@remkop22 remkop22 linked an issue Jul 5, 2023 that may be closed by this pull request
Parking tariff with grace period not working #52
Closed
@remkop22 remkop22 marked this pull request as ready for review July 5, 2023 10:08
@remkop22 remkop22 enabled auto-merge (squash) July 5, 2023 10:08
rudolphfroger
rudolphfroger approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@rudolphfroger rudolphfroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@remkop22 remkop22 merged commit c26006b into main Jul 5, 2023
@remkop22 remkop22 deleted the 52-parking-tariff-with-grace-period-not-working branch July 5, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolphfroger rudolphfroger rudolphfroger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parking tariff with grace period not working
2 participants
@remkop22 @rudolphfroger