Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tabel-mode #142

Merged
merged 5 commits into from
Nov 4, 2019
Merged

support tabel-mode #142

merged 5 commits into from
Nov 4, 2019

Conversation

xxbld
Copy link
Contributor

@xxbld xxbld commented Oct 13, 2019

support tabel-mode
allow scopedSlots.default as item-mode compontent render;
item type: set [Function, Object],

allow scopedSlots.default as item-mode compontent render;
item  type: set [Function, Object],
@tangbc
Copy link
Owner

tangbc commented Oct 18, 2019

Something wrong with npm run test:

=============================== Coverage summary ===============================
Statements   : 68.61% ( 153/223 )
Branches     : 55.44% ( 107/193 )
Functions    : 78.13% ( 25/32 )
Lines        : 68.33% ( 151/221 )
================================================================================
Test Suites: 10 failed, 4 passed, 14 total
Tests:       18 failed, 11 passed, 29 total
Snapshots:   0 total
Time:        5.524s

@xxbld
Copy link
Contributor Author

xxbld commented Oct 21, 2019

en...it`s something wrong in vue test
bowser this.$scopedSlots.default=undefined
jest this.$scopedSlots.default=function

image

image

@xxbld
Copy link
Contributor Author

xxbld commented Oct 21, 2019

@tangbc
Copy link
Owner

tangbc commented Oct 22, 2019

Some conflicts to master.

@tangbc
Copy link
Owner

tangbc commented Oct 25, 2019

Still have conflicts now?

@xxbld
Copy link
Contributor Author

xxbld commented Oct 25, 2019

Still have conflicts now?

no conflicts , least changes.
but vue test bug still

change $scopedSlots.default to $scopedSlots.item
@xxbld
Copy link
Contributor Author

xxbld commented Nov 4, 2019

@tangbc
can you review this pr?

changed $scopedSlots.default to $scopedSlots.item
and jest passed

https://vuejs.org/v2/api/#vm-scopedSlots

All $slots are now also exposed on $scopedSlots as functions. If you work with render functions, it is now recommended to always access slots via $scopedSlots, whether they currently use a scope or not. This will not only make future refactors to add a scope simpler, but also ease your eventual migration to Vue 3, where all slots will be functions.

@tangbc
Copy link
Owner

tangbc commented Nov 4, 2019

@tangbc
can you review this pr?

changed $scopedSlots.default to $scopedSlots.item
and jest passed

https://vuejs.org/v2/api/#vm-scopedSlots

All $slots are now also exposed on $scopedSlots as functions. If you work with render functions, it is now recommended to always access slots via $scopedSlots, whether they currently use a scope or not. This will not only make future refactors to add a scope simpler, but also ease your eventual migration to Vue 3, where all slots will be functions.

OK

@tangbc tangbc merged commit 5c8f5f2 into tangbc:master Nov 4, 2019
@MoazAlkharfan
Copy link

No thead support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants