Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tangle-dapp): Update restaking page organization #2711

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from

Conversation

yurixander
Copy link
Member

@yurixander yurixander commented Dec 23, 2024

Summary of changes

Provide a detailed description of proposed changes.

  • ➕ Added missing 404 page.
  • ➕ Added and implemented a generic list modal component that allows the selection of various things, such as operators, assets, etc. This will help improve consistency in design, search/filtering, and also empty & loading states ([TASK] Standardize & unify list-style modals #2715).
  • 🔧 Moved the positioning and layout of the restake actions to be under a Restake tab.
  • 🎨 Made some design updates to match the updated designs in Figma (eg. updating the button's disabled state background color, smaller paddings for cards, etc.).
  • 🎨 Fixed a design bug where the purple background gradient wasn't shown on light theme.
  • 🎨 Fixed icon sizing which caused all icons to be overly large.
  • 🐛 Fixed some bugs on mobile viewports that was causing legacy Hubble bridge information to show up.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

Screenshot 2024-12-30 at 22 54 37
Screenshot 2024-12-30 at 22 55 55
Screenshot 2024-12-30 at 22 56 21
Screenshot 2024-12-30 at 22 56 37
Screenshot 2024-12-30 at 22 55 35
Screenshot 2024-12-31 at 18 12 14
Screenshot 2024-12-31 at 18 12 43

@yurixander yurixander self-assigned this Dec 23, 2024
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit bf61d44
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/6775b1586cfcc60008d42007
😎 Deploy Preview https://deploy-preview-2711--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit bf61d44
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/6775b158c603c80008b85db9
😎 Deploy Preview https://deploy-preview-2711--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yurixander
Copy link
Member Author

yurixander commented Dec 25, 2024

What's left in this PR:

  • Finishing up the restake action tabs on the restake page, as they were moved from pages to tabs
  • Checking design & light theme after those changes
  • Checking Figma and comparing whether any other changes are missing for this task
  • Center & fix design of 'No asset/operator found' modals. Currently, they appear a bit off place.
  • Confirm with @monaiuu on whether some changes on the original task are still relevant or outdated.
  • Finish up implementation of standardized list modals.

@yurixander yurixander marked this pull request as ready for review December 31, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Building 🏗️
1 participant