Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests #13

Merged
merged 18 commits into from
Aug 11, 2021
Merged

Integration tests #13

merged 18 commits into from
Aug 11, 2021

Conversation

kmadk
Copy link
Contributor

@kmadk kmadk commented Aug 4, 2021

No description provided.

kmadk added 2 commits August 4, 2021 15:06
@kmadk
Integration tests with native verifier
056b483 
Nonce is now updated upon and emmited upon anchor deposit
@kmadk
Merge branch 'main' of https://github.com/webb-tools/protocol-solidity …
c564c16 
…into integration-tests
@kmadk kmadk requested a review from drewstone August 4, 2021 19:19
drewstone
drewstone requested changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you'll want to rebase/merge main in and then update your paths for the zkey and any circom circuit artifacts to the test/fixtures.

contracts/anchors/bridged/AnchorPoseidon2.sol Outdated Show resolved Hide resolved
contracts/anchors/bridged/AnchorPoseidon2.sol Outdated Show resolved Hide resolved
test/integration/twoChainIntegration.js Outdated Show resolved Hide resolved
kmadk and others added 4 commits August 5, 2021 01:55
drewstone
drewstone requested changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still concerns over unneeded nonce value. Inserted index is likely the "nonce" you're looking for.

contracts/anchors/bridged/AnchorPoseidon2.sol Outdated Show resolved Hide resolved
drewstone
drewstone requested changes Aug 5, 2021
View reviewed changes
test/integration/twoChainIntegration.js Outdated Show resolved Hide resolved
test/integration/twoChainIntegration.js Outdated Show resolved Hide resolved
test/integration/twoChainIntegration.js Outdated Show resolved Hide resolved
test/integration/twoChainIntegration.js Outdated Show resolved Hide resolved
test/integration/twoChainIntegration.js Outdated Show resolved Hide resolved
test/integration/twoChainIntegration.js Outdated Show resolved Hide resolved
test/integration/twoChainIntegration.js Outdated Show resolved Hide resolved
test/integration/twoChainIntegration.js Outdated Show resolved Hide resolved
test/integration/twoChainIntegration.js Outdated Show resolved Hide resolved
@kmadk kmadk requested a review from drewstone August 9, 2021 01:21
drewstone
drewstone requested changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @KeltonMad. Some changes here which may fix your failing tests.

contracts/anchors/bridged/AnchorPoseidon2.sol Outdated Show resolved Hide resolved
test/integration/multipleDepositWithdraw.js Outdated Show resolved Hide resolved
test/integration/multipleDepositWithdraw.js Show resolved Hide resolved
test/integration/multipleDepositWithdraw.js Outdated Show resolved Hide resolved
test/integration/multipleDepositWithdraw.js Outdated Show resolved Hide resolved
@drewstone drewstone merged commit 9083a2c into main Aug 11, 2021
@drewstone drewstone deleted the integration-tests branch August 11, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmadk @drewstone