Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neighbor root histories #15

Merged
merged 22 commits into from
Aug 12, 2021
Merged

Neighbor root histories #15

merged 22 commits into from
Aug 12, 2021

Conversation

kmadk
Copy link
Contributor

@kmadk kmadk commented Aug 10, 2021

No description provided.

@kmadk kmadk requested review from drewstone and nepoche August 10, 2021 23:12
Comment on lines +175 to +176
// insert two commitments into the tree
await tree.insert(firstOriginDeposit.commitment);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

kmadk and others added 2 commits August 11, 2021 09:58
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but not exactly how we discussed it. The roots passed into the contract should be a string of bytes arbitrarily. We will parse it into the size we expect and so on and so forth.

contracts/anchors/bridged/AnchorPoseidon2.sol Outdated Show resolved Hide resolved
contracts/anchors/bridged/AnchorPoseidon2.sol Outdated Show resolved Hide resolved
contracts/anchors/bridged/AnchorPoseidon2.sol Show resolved Hide resolved
@drewstone drewstone merged commit aee3711 into main Aug 12, 2021
@drewstone drewstone deleted the neighbor-root-histories branch August 12, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants