Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always deploy with governor as admin and transfer ownership after #173

Merged
merged 5 commits into from
Aug 2, 2022
Merged

Always deploy with governor as admin and transfer ownership after #173

merged 5 commits into from
Aug 2, 2022

Conversation

nepoche
Copy link
Contributor

@nepoche nepoche commented Jul 29, 2022

No description provided.

drewstone
drewstone approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nepoche nepoche changed the title Set bridge sides on the VBridge after all initialization has occurred Always deploy with governor as admin and transfer ownership after Jul 29, 2022
@nepoche nepoche requested a review from shekohex July 29, 2022 20:32
shekohex
shekohex requested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I left a few comments to improve this a bit, like adding docs and improve some parts in the tests.

packages/bridges/src/SignatureBridgeSide.ts Outdated Show resolved Hide resolved
test/vbridge/signatureVBridge.test.ts Outdated Show resolved Hide resolved
@nepoche nepoche requested a review from shekohex August 1, 2022 21:22
shekohex
shekohex approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nepoche nepoche merged commit f2bc27b into main Aug 2, 2022
@nepoche nepoche deleted the nathan/vbridge-set-bridgeside-after branch August 2, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekohex shekohex shekohex approved these changes

@drewstone drewstone drewstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nepoche @drewstone @shekohex