Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes propose tests and prepares cast vote tests for fixing. #20

Merged
merged 7 commits into from
Aug 13, 2021
Merged

Fixes propose tests and prepares cast vote tests for fixing. #20

merged 7 commits into from
Aug 13, 2021

Conversation

drewstone
Copy link
Contributor

No description provided.

@drewstone drewstone requested a review from kmadk August 13, 2021 05:30
kmadk
kmadk reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@kmadk kmadk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It would be helpful for to have a short list in notion of the residual holdups with the propose migration if you want me to take this over. If not I will begin doing each of the different tests subtypes as a branch as you said in notion

@drewstone
Copy link
Contributor Author

drewstone commented Aug 13, 2021 •
edited
Loading

There is all but 1 CastVote test not working when you run with a local hardhat node in a separate terminal. With normal yarn test a few CastVote tests fail. @KeltonMad

@drewstone drewstone merged commit 35c8f45 into main Aug 13, 2021
@drewstone drewstone deleted the propose-test branch August 13, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmadk kmadk kmadk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewstone @kmadk