Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build sequence and type chian generated files #220

Merged
merged 6 commits into from
Dec 20, 2022
Merged

Fix build sequence and type chian generated files #220

merged 6 commits into from
Dec 20, 2022

Conversation

AhmedKorim
Copy link
Contributor

No description provided.

@AhmedKorim AhmedKorim marked this pull request as draft December 19, 2022 13:25
@shekohex shekohex mentioned this pull request Dec 19, 2022
Merged
7 tasks
@AhmedKorim AhmedKorim marked this pull request as ready for review December 19, 2022 16:45
AtelyPham
AtelyPham reviewed Dec 20, 2022
View reviewed changes
Copy link
Member

@AtelyPham AtelyPham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add "module" and "types" properties in the packages/contracts/package.json file.

@AhmedKorim
Copy link
Contributor Author

@AtelyPham Not sure if you should or shouldn't do that but it's working fine with the current value

@AhmedKorim AhmedKorim requested a review from drewstone December 20, 2022 14:33
@shekohex shekohex requested a review from AtelyPham December 20, 2022 15:01
@drewstone drewstone merged commit 18e0ebc into main Dec 20, 2022
@drewstone drewstone deleted the ahmed/fix-build branch December 20, 2022 15:27
@salman01zp salman01zp mentioned this pull request Jan 10, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone Awaiting requested review from drewstone

@AtelyPham AtelyPham Awaiting requested review from AtelyPham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AhmedKorim @AtelyPham @drewstone @shekohex