Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labelling circom inputs public/private #45

Merged
merged 4 commits into from
Oct 24, 2021
Merged

labelling circom inputs public/private #45

merged 4 commits into from
Oct 24, 2021

Conversation

akileshtangella
Copy link
Contributor

No description provided.

drewstone
drewstone requested changes Oct 24, 2021
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to add public defs to the test components. I would also use hyphens to separate when the comment adds some extra details.

@drewstone drewstone merged commit 914f299 into eth-lisbon Oct 24, 2021
@drewstone drewstone deleted the eth-lisbon-circomlabel branch November 3, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akileshtangella @drewstone