Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webb-Solidity package structure #65

Merged
merged 27 commits into from
Nov 29, 2021
Merged

Webb-Solidity package structure #65

merged 27 commits into from
Nov 29, 2021

Conversation

nepoche
Copy link
Contributor

@nepoche nepoche commented Nov 27, 2021

This PR changes the project structure to separate packages:

  • contracts: types of the latest solidity contracts
  • fixed-bridge: Wrapper-classes for anchors, bridges, etc. related to fixed-bridge.
  • tokens: Wrapper-classes for token functionality
  • utils: Common utilities e.g. toFixedHex and others.
  • vbridge: UNIMPLEMENTED, wrapper-classes for anchors, bridges, etc. related to variable bridges.

This PR brings in a dependency on lerna for building and publishing the packages.

This PR updates the root-directory package.json to include:

  • yarn build:packages - needs to be run before tests.
  • yarn compile - should be run instead of npx hardhat compile as it will run a script to update the src files in the contracts directory of the latest typechain output.

@nepoche nepoche requested review from drewstone and akileshtangella and removed request for drewstone November 27, 2021 04:45
@drewstone
Copy link
Contributor

drewstone commented Nov 27, 2021

Awesome work, first glance is # of files / lines changed is huge. Maybe we're committing something we shouldn't be. Phone isn't loading commits easily..

EDIT: Looks like mostly TS type files. I presume we're not using a large majority of them for anything. We should remove and try to shrink the size of these types, isolating them as much as possible if not already done. Wdyt?

@nepoche nepoche marked this pull request as ready for review November 29, 2021 18:20
@nepoche nepoche merged commit c9f99a4 into tangle-network:main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants