Group/v2 #89
Merged
Group/v2 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewstone
requested changes
Dec 27, 2021
packages/fixed-bridge/src/Anchor.ts
Outdated
| @@ -194,20 +194,24 @@ class Anchor { | |||
|
|
|||
| // Proposal data is used to update linkedAnchors via bridge proposals | |||
| // on other chains with this anchor's state | |||
| public async getProposalData(leafIndex?: number): Promise<string> { | |||
| public async getProposalData(executionAnchor: Anchor, leafIndex?: number): Promise<string> { | |||
There was a problem hiding this comment.
I think we should pass in the resourceID rather than the entire Anchor class.
| @@ -54,8 +54,8 @@ export class BridgeSide { | |||
| *** make its way to the neighbor root of the linked anchor on chain X. | |||
| *** @param linkedAnchorInstance: the anchor instance on the opposite chain | |||
| ***/ | |||
| public async createAnchorUpdateProposalData(linkedAnchorInstance: Anchor) { | |||
| const proposalData = await linkedAnchorInstance.getProposalData(); | |||
| public async createAnchorUpdateProposalData(linkedAnchorInstance: Anchor, thisAnchorInstance: Anchor) { | |||
There was a problem hiding this comment.
This isn't a good naming scheme, lets avoid thisAnchorInstance please. Propose other names if you're unsure.
| public async createAnchorUpdateProposalData(linkedAnchorInstance: Anchor) { | ||
| const proposalData = await linkedAnchorInstance.getProposalData(); | ||
| public async createAnchorUpdateProposalData(linkedAnchorInstance: Anchor, thisAnchorInstance: Anchor) { | ||
| const proposalData = await linkedAnchorInstance.getProposalData(thisAnchorInstance); |
There was a problem hiding this comment.
Lets also just call the get resourceID method and pass that result to the anchor whose state we are fetching.
|
There's a lot more to be fixed in these classes @saiakilesh. Naming can certainly be improved and how proposals are created can be improved too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.