Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vbridge.ts has signature bridge functionality #95

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Conversation

akileshtangella
Copy link
Contributor

@akileshtangella akileshtangella commented Jan 3, 2022

I tried creating an IBridgeSide interface and having the SignatureBridgeSide and VBridgeSide classes implement it. But doing this ended up being messy. Some concrete reasons include:

  1. Some of the shared methods between VBridgeSide and SignatureBridgeSide such as createBridgeSide have different function signatures.
  2. SignatureBridgeSide does not have voteProposal methods so I would have to create empty voteProposal methods in order to implement the interface.

So, I stuck with the original SPEC.

@drewstone drewstone merged commit e2d2e94 into main Jan 4, 2022
@drewstone drewstone deleted the akilesh/SigVBridge branch January 4, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPEC] Integrate Signature Bridge functionality for VAnchors into classes
2 participants