vbridge.ts has signature bridge functionality #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried creating an
IBridgeSide
interface and having theSignatureBridgeSide
andVBridgeSide
classes implement it. But doing this ended up being messy. Some concrete reasons include:VBridgeSide
andSignatureBridgeSide
such ascreateBridgeSide
have different function signatures.SignatureBridgeSide
does not havevoteProposal
methods so I would have to create emptyvoteProposal
methods in order to implement the interface.So, I stuck with the original SPEC.