signing with nonce #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewstone
requested changes
Jan 3, 2022
| function transferOwnershipWithSignature(address newOwner, bytes memory sig) public { | ||
| function transferOwnershipWithSignature(address newOwner, uint32 nonce, bytes memory sig) public { | ||
| require(refreshNonce < nonce, "Invalid nonce"); | ||
| require(nonce <= refreshNonce + 1, "Nonce must increment by 1"); |
There was a problem hiding this comment.
We need to add checks that nonce doesn't increase tremendously (causing overflow attack).
There was a problem hiding this comment.
Oops I had it backwards. This looks good.
What does hound more nonce updates mean? I didn't understand. |
|
Bound* |
Ah ok cool. |
drewstone
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signing
hash(nonce, publicKey)