Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Proxy contracts #12

Closed
wants to merge 4 commits into from
Closed

feat: Proxy contracts #12

wants to merge 4 commits into from

Conversation

shekohex
Copy link
Contributor

@shekohex shekohex commented Oct 10, 2024

This pull request includes significant additions to the Proxy.sol contract and its related test file Proxy.t.sol. The main changes involve the introduction of a new proxy contract system with comprehensive functionality and corresponding tests.

Proxy Contract:

  • New Proxy Contract System: Added a new proxy contract system in src/Proxy.sol, including the Singleton, IProxy, Proxy, and ProxyFactory contracts. These contracts facilitate the creation and management of proxy contracts, allowing for efficient transaction execution and contract deployment. originally from Gnosis Safe contracts.

Testing:

  • Proxy Contract Tests: Added a comprehensive test suite in test/Proxy.t.sol to ensure the correct functionality of the new proxy contract system. This includes tests for proxy creation, initialization, and callback mechanisms.

@shekohex shekohex marked this pull request as ready for review October 10, 2024 12:48
@shekohex shekohex requested a review from drewstone October 10, 2024 14:21
@shekohex shekohex marked this pull request as draft October 10, 2024 14:26
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, why not use OpenZeppelin tooling instead? The less we need audited the better.

@shekohex shekohex closed this Oct 17, 2024
@shekohex shekohex deleted the shady/proxy branch November 22, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants