Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new query to get Developer Payment address #42

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

shekohex
Copy link
Contributor

@shekohex shekohex commented Nov 28, 2024

This pull request introduces a new function to query the developer payment address in the BlueprintServiceManagerBase contract and its corresponding interface IBlueprintServiceManager. The most important changes include:

Additions to Blueprint Service Manager:

  • Added the queryDeveloperPaymentAddress function to the BlueprintServiceManagerBase contract to allow querying the developer payment address. This function returns the address of the blueprint owner.

Interface Updates:

  • Updated the IBlueprintServiceManager interface to include the new queryDeveloperPaymentAddress function. This function is intended for use by the runtime or the Master Blueprint Service Manager to determine the developer payment address for a service.

Closes #31

Copy link

github-actions bot commented Nov 28, 2024

LCOV of commit 558d9d4 during Foundry CI #12

Summary coverage rate:
  lines......: 0.0% (0 of 55 lines)
  functions..: 0.0% (0 of 35 functions)
  branches...: 0.0% (0 of 2 branches)

Files changed coverage rate:
                                       |Lines       |Functions  |Branches    
  Filename                             |Rate     Num|Rate    Num|Rate     Num
  ===========================================================================
  src/BlueprintServiceManagerBase.sol  | 0.0%      6| 0.0%    16|    -      0

⛔ The code coverage is too low: 0. Expected at least 85.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/BlueprintServiceManagerBase.sol: Language not supported
  • src/IBlueprintServiceManager.sol: Language not supported
@shekohex shekohex merged commit c318e61 into main Nov 28, 2024
1 of 2 checks passed
@shekohex shekohex deleted the shady/dev-payment-addr branch November 28, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Implement custom payment address support
1 participant