Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
foundry.toml
configuration file and multiple Solidity files to enhance the Blueprint Service Manager's functionality and improve code readability. The most important changes include updates to thefoundry.toml
file, restructuring of theBlueprintServiceManagerBase
contract, and the introduction of new data structures and enums in theIBlueprintServiceManager.sol
file.Configuration Updates:
foundry.toml
: Adjustedline_length
from 132 to 120 and increaseddepth
from 100 to 120. [1] [2]Solidity Contract Enhancements:
BlueprintServiceManagerBase.sol
: Refactored functionsonUpdatePriceTargets
,onRequest
, andonReject
to improve readability and maintainability. [1] [2]New Data Structures and Enums:
IBlueprintServiceManager.sol
: IntroducedAssetKind
enum andAsset
andRequestParams
structs to represent assets and service request parameters. UpdatedonRequest
function to useRequestParams
struct. [1] [2] [3] [4]Event and Function Updates:
MasterBlueprintServiceManager.sol
: UpdatedServiceRequested
event to includeasset
andamount
parameters. RefactoredonRequest
andonServiceTermination
functions to use the newRequestParams
struct and improve code readability. [1] [2] [3]These changes collectively improve the maintainability, readability, and functionality of the Blueprint Service Manager contracts and configuration.
Closes #28