Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ERC20 and AssetId support #43

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

shekohex
Copy link
Contributor

@shekohex shekohex commented Dec 4, 2024

This pull request includes several changes to the foundry.toml configuration file and multiple Solidity files to enhance the Blueprint Service Manager's functionality and improve code readability. The most important changes include updates to the foundry.toml file, restructuring of the BlueprintServiceManagerBase contract, and the introduction of new data structures and enums in the IBlueprintServiceManager.sol file.

Configuration Updates:

  • foundry.toml: Adjusted line_length from 132 to 120 and increased depth from 100 to 120. [1] [2]

Solidity Contract Enhancements:

New Data Structures and Enums:

  • IBlueprintServiceManager.sol: Introduced AssetKind enum and Asset and RequestParams structs to represent assets and service request parameters. Updated onRequest function to use RequestParams struct. [1] [2] [3] [4]

Event and Function Updates:

  • MasterBlueprintServiceManager.sol: Updated ServiceRequested event to include asset and amount parameters. Refactored onRequest and onServiceTermination functions to use the new RequestParams struct and improve code readability. [1] [2] [3]

These changes collectively improve the maintainability, readability, and functionality of the Blueprint Service Manager contracts and configuration.

Closes #28

Copy link

github-actions bot commented Dec 4, 2024

LCOV of commit 18dbe7e during Foundry CI #16

Summary coverage rate:
  lines......: 0.0% (0 of 163 lines)
  functions..: 0.0% (0 of 56 functions)
  branches...: 0.0% (0 of 13 branches)

Files changed coverage rate:
                                       |Lines       |Functions  |Branches    
  Filename                             |Rate     Num|Rate    Num|Rate     Num
  ===========================================================================
  src/BlueprintServiceManagerBase.sol  | 0.0%     22| 0.0%    16|    -      0
  src/MasterBlueprintServiceManager.sol| 0.0%     58| 0.0%    15|    -      0
  test/MockERC20.sol                   | 0.0%     73| 0.0%    21| 0.0%     11

⛔ The code coverage is too low: 0. Expected at least 85.

@shekohex shekohex requested review from Copilot and drewstone December 6, 2024 13:59
@shekohex shekohex marked this pull request as ready for review December 6, 2024 13:59

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 5 changed files in this pull request and generated no suggestions.

Files not reviewed (4)
  • src/BlueprintServiceManagerBase.sol: Language not supported
  • src/IBlueprintServiceManager.sol: Language not supported
  • src/MasterBlueprintServiceManager.sol: Language not supported
  • test/MockERC20.sol: Language not supported
@drewstone drewstone merged commit df6d5d6 into main Dec 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Implement multi-token payment support
2 participants