Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use milliseconds for duration in Marker setPointEased #1298

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Use milliseconds for duration in Marker setPointEased #1298

merged 1 commit into from
Feb 16, 2017

Conversation

matteblair
Copy link
Member

Resolves #1264

tallytalwar
tallytalwar reviewed Feb 15, 2017
View reviewed changes
Copy link
Member

@tallytalwar tallytalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update ios platform here?

@matteblair
Copy link
Member Author

matteblair commented Feb 15, 2017 •
edited
Loading

@tallytalwar The iOS interface appears to be consistent here, it uses seconds for all durations. Apple's UIKit animations use seconds as well, so I think this is the right choice (example: https://developer.apple.com/reference/uikit/uiview/1622617-setanimationduration).

@matteblair
Copy link
Member Author

I will, however, change the name of the 'duration' parameters in TGMapViewController, to clarify the units.

tallytalwar
tallytalwar approved these changes Feb 15, 2017
View reviewed changes
Copy link
Member

@tallytalwar tallytalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant the function parameter only. Also a note to @karimnaaji to incorporate this in the documentation.

@karimnaaji
Copy link
Member

@tallytalwar updated the param name to seconds in #1290 .

@tallytalwar
Copy link
Member

Need to rebase and resolve conflicts, good to go when done.

@matteblair matteblair merged commit 0b33fe5 into master Feb 16, 2017
@matteblair matteblair deleted the fix-marker-duration branch February 16, 2017 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallytalwar tallytalwar tallytalwar approved these changes

@karimnaaji karimnaaji karimnaaji approved these changes

Assignees
No one assigned
Labels
bug ready for review small-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteblair @karimnaaji @tallytalwar