Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure onRegionDidChange gets called after an immediate camera update #2160

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Ensure onRegionDidChange gets called after an immediate camera update #2160

merged 1 commit into from
Jul 25, 2020

Conversation

matteblair
Copy link
Member

@matteblair matteblair commented May 10, 2020 •
edited
Loading

Resolves #2129

Need to:

  • Add code comments explaining what this fixes
  • Ensure that other behavior isn't changed on Android
  • Ensure that iOS callback behavior isn't changed

@matteblair matteblair force-pushed the updatecamera-regiondidchange branch from 632e297 to 632a887 Compare July 25, 2020 20:15
@matteblair matteblair force-pushed the updatecamera-regiondidchange branch from 632a887 to b08c3f3 Compare July 25, 2020 23:34
@matteblair matteblair marked this pull request as ready for review July 25, 2020 23:34
@matteblair matteblair merged commit b2c0467 into master Jul 25, 2020
@matteblair matteblair deleted the updatecamera-regiondidchange branch July 25, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: No MapChangeListener callback when updating camera position
1 participant
@matteblair