Remove Type shadowing from C# Type #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimnaaji
changed the title
karimnaaji
force-pushed
the
type-shadowing
branch
from
3436647
to
d6784a0
Compare
matteblair
reviewed
Nov 2, 2017
There was a problem hiding this comment.
I would suggest that we make these Enums separate (not nested) type declarations. This seems to be a common and recommended practice in C# (https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/nested-types)
Edit: I'm guilty of only partially following this guideline so far - GeometryType is declared on its own but in another PR I added the UVMode Enum as a nested type, which I'll now update.
|
Makes sense after reading the guidelines, will refactor all nested types after #81, rebasing will be more convenient this way. Closing for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.