fix sveltejs#4562

tanhauhau · Mar 16, 2020 · 20f1513 · 20f1513
1 parent 40c5df5
commit 20f1513
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 1 deletion.
diff --git a/src/compiler/compile/render_dom/wrappers/Slot.ts b/src/compiler/compile/render_dom/wrappers/Slot.ts
@@ -38,6 +38,7 @@ export default class SlotWrapper extends Wrapper {
 				name: this.renderer.component.get_unique_name(`fallback_block`),
 				type: 'fallback'
 			});
+			renderer.blocks.push(this.fallback);
 		}
 
 		this.fragment = new FragmentWrapper(
@@ -115,7 +116,6 @@ export default class SlotWrapper extends Wrapper {
 
 		if (this.fallback) {
 			this.fragment.render(this.fallback, null, x`#nodes` as Identifier);
-			renderer.blocks.push(this.fallback);
 		}
 
 		const slot = block.get_unique_name(`${sanitize(slot_name)}_slot`);

diff --git a/test/runtime/samples/component-slot-fallback-3/Inner.svelte b/test/runtime/samples/component-slot-fallback-3/Inner.svelte
@@ -0,0 +1,6 @@
+<slot>
+	<div>Hello</div>
+	<div>world</div>
+	<div>Bye</div>
+	<div>World</div>
+</slot>
diff --git a/test/runtime/samples/component-slot-fallback-3/_config.js b/test/runtime/samples/component-slot-fallback-3/_config.js
@@ -0,0 +1,6 @@
+export default {
+	html: `
+	<div>Hello World</div>
+	<div>Hello</div><div>world</div><div>Bye</div><div>World</div>
+	`,
+};
diff --git a/test/runtime/samples/component-slot-fallback-3/main.svelte b/test/runtime/samples/component-slot-fallback-3/main.svelte
@@ -0,0 +1,9 @@
+<script>
+	import Inner from "./Inner.svelte";
+</script>
+
+<Inner>
+	<div>Hello World</div>
+</Inner>
+
+<Inner></Inner>