chore(build.py): add cli flag to use podman instead of docker #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podman's cli is arg-compatible with docker, at least for building images. We can allow users to specify an alternate build engine.
matthauck
reviewed
Jan 30, 2024
build.py
Outdated
| @@ -6,6 +6,9 @@ | |||
| import subprocess | |||
|
|
|||
| is_travis = os.environ.get('TRAVIS') is not None | |||
|
|
|||
| engine = os.environ.get('OCTOBOT_CONTAINER_BUILD_ENGINE', 'docker') | |||
There was a problem hiding this comment.
imo, a cli arg that explicitly chooses podman instead feels better than an env variable turning into shell execution. thoughts?
bblancha
changed the title
trevershick
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman's cli is arg-compatible with docker, at least for building images. We can allow users to specify use of podman.