Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace shared cost_tracker obj with bank.cost_tracker #2

Closed
wants to merge 36 commits into from
Closed

Replace shared cost_tracker obj with bank.cost_tracker #2

wants to merge 36 commits into from

Conversation

tao-stones
Copy link
Owner

Problem

After solana-labs#20527, TPU and Banking_stage should invoke cost_tracker from bank, instead of sharing (and trying to sync) one cost_tracker object between banking stage threads.

Summary of Changes

  • remove shared cost_tracker obj
  • decouple cost_model from cost_tracker

Fixes #

jeffwashington and others added 9 commits October 11, 2021 12:46
@jeffwashington
add filler accounts to bloat validator and predict failure (solana-la…
a8e000a 
…bs#20491)

* add filler accounts to bloat validator and predict failure

* assert no accounts match filler

* cleanup magic numbers

* panic if can't load from snapshot with filler accounts specified

* some renames

* renames

* into_par_iter

* clean filler accts, too
@dependabot
chore: bump ouroboros from 0.12.0 to 0.13.0 (solana-labs#20591)
9d94e43 
* chore: bump ouroboros from 0.12.0 to 0.13.0

Bumps [ouroboros](https://github.com/joshua-maros/ouroboros) from 0.12.0 to 0.13.0.
- [Release notes](https://github.com/joshua-maros/ouroboros/releases)
- [Commits](https://github.com/joshua-maros/ouroboros/commits)

---
updated-dependencies:
- dependency-name: ouroboros
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* [auto-commit] Update all Cargo lock files

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-buildkite <you@example.com>
@brson
Reorder RpcClient method defs for more logical docs. (solana-labs#20549)
1417c14 
Methods follow this order:

- Constructors
- send_and_confirm variations
- send variations
- confirm variations
- simulate variations
- queries
@jeffwashington
AcctIdx: write disk only when removing from mem (solana-labs#20578)
0da677e
@jstarry
docs: Remove outdated instructions for managing stake accounts (solan…
03d3e00 
…a-labs#20555)
@dependabot @CriesofCarrots
chore: bump ahash from 0.7.4 to 0.7.5 (solana-labs#20592)
a4c9b0f 
* chore: bump ahash from 0.7.4 to 0.7.5

Bumps [ahash](https://github.com/tkaitchuck/ahash) from 0.7.4 to 0.7.5.
- [Release notes](https://github.com/tkaitchuck/ahash/releases)
- [Commits](https://github.com/tkaitchuck/ahash/commits)

---
updated-dependencies:
- dependency-name: ahash
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump ahash patch

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyera Eulberg <tyera@solana.com>
@jackcmay
Add debug guard to catch invalid params (solana-labs#20603)
b0ee5d6
@jackcmay
Comprehensive compute fees (solana-labs#20531)
94ca506 
* Comprehensive fees proposal

* Updated
@mvines
Add test to ensure instructions sysvar behaves as expected from withi…
4623018 
…n a CPI
@tao-stones tao-stones force-pushed the move-tracker-to-bank branch from 095cf5d to 0df0f03 Compare October 12, 2021 04:03
dependabot bot and others added 5 commits October 12, 2021 08:07
@dependabot
chore:(deps): bump @types/react from 17.0.27 to 17.0.28 in /explorer (s…
133cce4 
…olana-labs#20614)

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 17.0.27 to 17.0.28.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore:(deps): bump superstruct from 0.15.2 to 0.15.3 in /explorer (so…
0f6a35c 
…lana-labs#20615)

Bumps [superstruct](https://github.com/ianstormtaylor/superstruct) from 0.15.2 to 0.15.3.
- [Release notes](https://github.com/ianstormtaylor/superstruct/releases)
- [Changelog](https://github.com/ianstormtaylor/superstruct/blob/main/Changelog.md)
- [Commits](ianstormtaylor/superstruct@v0.15.2...v0.15.3)

---
updated-dependencies:
- dependency-name: superstruct
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: bump jayson from 3.6.4 to 3.6.5 in /web3.js (solana-labs#20613)
f77c288 
Bumps [jayson](https://github.com/tedeh/jayson) from 3.6.4 to 3.6.5.
- [Release notes](https://github.com/tedeh/jayson/releases)
- [Commits](tedeh/jayson@v3.6.4...v3.6.5)

---
updated-dependencies:
- dependency-name: jayson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: bump ts-node from 10.2.1 to 10.3.0 in /web3.js (solana-labs#20616
a723de0 
)

Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 10.2.1 to 10.3.0.
- [Release notes](https://github.com/TypeStrong/ts-node/releases)
- [Commits](TypeStrong/ts-node@v10.2.1...v10.3.0)

---
updated-dependencies:
- dependency-name: ts-node
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tao-stones
- move cost tracker into bank, so each bank has its own cost tracker; (…
005d686 
…solana-labs#20527)

- move related modules to runtime
@tao-stones tao-stones force-pushed the invoke_tracker_from_bank__move-tracker-to-bank branch from c50e67a to 66f7ac6 Compare October 12, 2021 14:06
@tao-stones tao-stones force-pushed the invoke_tracker_from_bank__move-tracker-to-bank branch from b23420b to 1177785 Compare October 12, 2021 18:37
@tao-stones tao-stones force-pushed the invoke_tracker_from_bank__move-tracker-to-bank branch from 1177785 to d91c8e3 Compare October 12, 2021 22:14
roederw and others added 10 commits October 12, 2021 16:19
@roederw
explorer: Added an Error Image Placeholder and resolved a fetching is…
e6776ef 
…sue for NFT assets (solana-labs#20608)

* Fixed an issue where NFT assets were continually fetched if we failed to get the asset from a fetch.
Cleaned up/removed un-used NFT asset code.
Added an error image when we failed to fetch the asset.

* Corrected some fetching logic and added a error placeholder timeout since onError/onLoad are never fired for <img /> if the src is undefined
@jackcmay
Reduce budget request instruction length (solana-labs#20636)
c231cfe
@Lichtso
Refactor: Make program_id always last in program chain (solana-labs#2…
1d813ea 
…0598)

* Replaces program_id field in InvokeContextStackFrame by index.

* Swaps order of program account and programdata account.

* Removes program_id parameter from InvokeContext::push().
@sakridge
Refactor code to get block signatures in get_confirmed_signatures_for…
09e7782 
…_address2 (solana-labs#20575)

* Refactor get_confirmed_signatures_for_address2

* Move blockstore benches to ledger where they belong
@dependabot
chore:(deps): bump @types/node from 16.10.3 to 16.10.5 in /explorer (s…
3245042 
…olana-labs#20649)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 16.10.3 to 16.10.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore:(deps): bump @solana/spl-token-registry in /explorer (solana-la…
7bba642 
…bs#20648)

Bumps [@solana/spl-token-registry](https://github.com/solana-labs/token-list) from 0.2.274 to 0.2.275.
- [Release notes](https://github.com/solana-labs/token-list/releases)
- [Changelog](https://github.com/solana-labs/token-list/blob/main/CHANGELOG.md)
- [Commits](solana-labs/token-list@v0.2.274...v0.2.275)

---
updated-dependencies:
- dependency-name: "@solana/spl-token-registry"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore:(deps): bump @blockworks-foundation/mango-client in /explorer (s…
2b03ac1 
…olana-labs#20651)

Bumps [@blockworks-foundation/mango-client](https://github.com/blockworks-foundation/mango-client-v3) from 3.0.24 to 3.1.1.
- [Release notes](https://github.com/blockworks-foundation/mango-client-v3/releases)
- [Commits](https://github.com/blockworks-foundation/mango-client-v3/commits)

---
updated-dependencies:
- dependency-name: "@blockworks-foundation/mango-client"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: bump mockttp from 2.2.4 to 2.3.0 in /web3.js (solana-labs#20647)
f469af7 
Bumps [mockttp](https://github.com/httptoolkit/mockttp) from 2.2.4 to 2.3.0.
- [Release notes](https://github.com/httptoolkit/mockttp/releases)
- [Commits](httptoolkit/mockttp@v2.2.4...v2.3.0)

---
updated-dependencies:
- dependency-name: mockttp
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: bump eslint-plugin-import from 2.24.2 to 2.25.2 in /web3.js (s…
5a7c76b 
…olana-labs#20652)

Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.24.2 to 2.25.2.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.24.2...v2.25.2)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore:(deps): bump typescript from 4.4.3 to 4.4.4 in /explorer (solan…
a4f9ea7 
…a-labs#20654)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.4.3 to 4.4.4.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.4.3...v4.4.4)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 7 commits October 13, 2021 08:23
@dependabot
chore: bump @types/node from 16.10.3 to 16.10.5 in /web3.js (solana-l…
b4f146f 
…abs#20656)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 16.10.3 to 16.10.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sakridge
Add is_full to ledger-tool (solana-labs#20183)
3b40fa3
@sakridge
Move transaction executor (solana-labs#19946)
60fe29b
@jeffwashington
add clean stats (solana-labs#20631)
aec9d8b
@behzadnouri
uses nanos precision for timestamp when submitting metrics to influxdb (
cd87525 
solana-labs#20623)

Current datapoint_info! is apparently overwriting itself when run inside
a loop. For example in
https://github.com/solana-labs/solana/blob/005d6863f/core/src/window_service.rs#L101-L107
only one of the slots will show up in influxdb.

This is apparently because of metrics code using milliseconds as the
timestamp, as mentioned here:
solana-labs#19789 (comment)
@joeaba
testing
da0e570
@lijunwangs
Accountsdb plugin metrics (solana-labs#20606)
08e40bf 
Added metrics for accountsdb plugin
Handle and log postgres db errors
Print account pubkeys nicely in logging
@tao-stones tao-stones force-pushed the invoke_tracker_from_bank__move-tracker-to-bank branch from d91c8e3 to 0736ef7 Compare October 13, 2021 16:28
tao-stones and others added 3 commits October 13, 2021 11:43
@tao-stones
fix unstable test (solana-labs#20645)
220fd41
@roederw
Fixed video NFT asset dimensions and vertically centered ALL NFT art (s…
149d224 
…olana-labs#20666)
@tao-stones
- make cost_tracker a member of bank, remove shared instance from TPU;
5016276 
- decouple cost_model from cost_tracker; allowing one cost_model
  instance being shared within a validator;
- update cost_model api to calculate_cost(&self...)->transaction_cost
@tao-stones tao-stones force-pushed the invoke_tracker_from_bank__move-tracker-to-bank branch from 0736ef7 to 5016276 Compare October 13, 2021 19:25
tao-stones pushed a commit that referenced this pull request Apr 19, 2022
@yangli-io
fix: remove async for createProgramAddress and findProgramAddress (#2… (
a6742b5 
solana-labs#23185)

* fix: remove async for createProgramAddress and findProgramAddress (solana-labs#23184)

make sync

* test: add test to ensure backwards compatibility
@github-actions github-actions bot added the stale label Dec 12, 2022
@github-actions github-actions bot closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.