fix(core): Remove duplicate angular interceptor

Remove the interceptor defined in the users module
Update the interceptor defined in the core module
Update the respective test

Fixes #1096

modules/core/client/services/interceptors/auth.interceptor.client.service.js

@@ -1,12 +1,14 @@
 'use strict';
 
-angular.module('core').factory('authInterceptor', ['$q', '$injector',
-  function ($q, $injector) {
+angular.module('core').factory('authInterceptor', ['$q', '$injector', 'Authentication',
+  function ($q, $injector, Authentication) {
     return {
       responseError: function(rejection) {
         if (!rejection.config.ignoreAuthModule) {
           switch (rejection.status) {
             case 401:
+              // Deauthenticate the global user
+              Authentication.user = null;
               $injector.get('$state').transitionTo('authentication.signin');
               break;
             case 403:

modules/core/tests/client/interceptors/auth.interceptor.client.tests.js

@@ -6,6 +6,7 @@
     var authInterceptor,
       $q,
       $state,
+      Authentication,
       httpProvider;
 
     // Load the main application module
@@ -16,10 +17,11 @@
       httpProvider = $httpProvider;
     }));
 
-    beforeEach(inject(function(_authInterceptor_, _$q_, _$state_) {
+    beforeEach(inject(function(_authInterceptor_, _$q_, _$state_, _Authentication_) {
       authInterceptor = _authInterceptor_;
       $q = _$q_;
       $state = _$state_;
+      Authentication = _Authentication_;
       spyOn($q,'reject');
       spyOn($state,'transitionTo');
     }));
@@ -56,6 +58,7 @@
         };
         var promise = authInterceptor.responseError(response);
         expect($q.reject).toHaveBeenCalled();
+        expect(Authentication.user).toBe(null);
         expect($state.transitionTo).toHaveBeenCalledWith('authentication.signin');
       });
     });