Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
…ue` (@RolT) Before this commit: (freeze true) => froze as primitive `true` (freeze false) => froze as primitive `false` (freeze (Boolean. <anything>)) => froze as primitive `true` After this commit: Boxed Booleans are first unboxed to correct primitive value before freezing This was a long-standing bug, though thankfully unlikely to have affected most users since boxed Booleans are rarely used in Clojure. Cases with Java interop are the most likely to have been affected. A big thanks to Roland Thiolliere (@RolT) for this fix!
- Loading branch information
8909a32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Peter, thanks for pushing this release.
I have one small observation however: according to the clojure reference, they suggest using
(Boolean/valueOf false)
and(Boolean/valueOf true)
instead of the constructors. Would you like me to do a PR to update it to be on the safe side?8909a32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edporras Hi Ed- I'm sorry, I'm not sure I follow. Where exactly are you proposing to use
Boolean/valueOf
?8909a32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, I apologize. I was looking at this through a collapsed view on GitHub and missed that the instance of
(Boolean. false)
was part of your stress data. Sorry about that!8909a32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem at all, it's always useful to get extra eyes on things like this to help make sure that everything is correct. Much appreciated 👍 Cheers :-)