Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer public API for Nippy type info #151

Closed
ptaoussanis opened this issue Jul 19, 2022 · 3 comments
Closed

Offer public API for Nippy type info #151

ptaoussanis opened this issue Jul 19, 2022 · 3 comments

Comments

@ptaoussanis
Copy link
Member

Relevant for: #147, #140 (esp. comment).

Nippy's data format consists of 2x main parts:

  1. Nippy's internal schema: mostly just the set of [byte-id type length] tuples.
  2. The encoding of base types as per java.io.DataOutput and optional compression/encryption.

(1) is currently defined by a private var (nippy/type-ids).

The discussion on #140 concluded that it'd be useful for (1) to be made somehow public.

Just making the current nippy/type-ids private var public would not be ideal- we can probably offer a more convenient API to the same info.

Comments/PRs welcome for ideas, otherwise I'll try take a look at this next time I'm doing some batched work on Nippy.

@ptaoussanis
Copy link
Member Author

@refset Hi Jeremy, just checking if this issue is still relevant for you?
I'm prioritising open-source work atm, and this is a candidate for one of my next tasks.

Thanks

@ptaoussanis
Copy link
Member Author

ptaoussanis commented Oct 14, 2022

@refset I had an opportunity today, so just went ahead with this.
Have pushed [com.taoensso/nippy "3.3.0-alpha2"] to Clojars with the following experimental new var.

From my understanding of your objective, this should hopefully allow you to write a much simpler version of your get-len utility.

Feedback welcome.

Cheers

@refset
Copy link

refset commented Oct 14, 2022

Hey @ptaoussanis - thanks a lot for this, it looks great :) we'll try to find some time to kick the tyres properly soon!

@ptaoussanis ptaoussanis removed this from the v3.3 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants