Bump browser-run to support sandbox option. Closes #82

tape-testing · Apr 12, 2021 · 57adc5f · 57adc5f
1 parent ccad1ea
commit 57adc5f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -122,9 +122,10 @@ on `http://localhost:<port>` and tests will be run there.
   * `ie`
   * `phantom`
   * `safari`
-* `keepOpen` (Boolean): Leave the browser open for debugging after running tests.
-* `node` (Boolean): Enable nodejs integration for electron.
-* `basedir` (String): Set this if you need to require node modules in `node` mode
+* `keepOpen (Boolean)`: Leave the browser open for debugging after running tests.
+* `node (Boolean)` Enable nodejs integration for electron.
+* `sandbox (Boolean) [Default: true]`: Enable electron sandbox.
+* `basedir` (String): Set this if you need to require node modules in `node` mode.
 
 The **CLI** takes the same arguments, plus `--render` (see blow):
 
@@ -134,15 +135,16 @@ Pipe a browserify stream into this.
 browserify [opts] [files] | tape-run [opts]
 
 Options:
-  --wait       Timeout for tap-finished                                                                                
-  --port       Wait to be opened by a browser on that port                                                             
-  --static     Serve static files from this directory                                                                  
+  --wait       Timeout for tap-finished
+  --port       Wait to be opened by a browser on that port
+  --static     Serve static files from this directory
   --browser    Browser to use. Always available: electron. Available if installed: chrome, firefox, ie, phantom, safari  [default: "electron"]
-  --render     Command to pipe tap output to for custom rendering                                                      
-  --keep-open  Leave the browser open for debugging after running tests                                                
-  --node       Enable nodejs integration for electron                                                                  
-  --basedir    Set this if you need to require node modules in node mode                                               
-  --help       Print usage instructions  
+  --render     Command to pipe tap output to for custom rendering
+  --keep-open  Leave the browser open for debugging after running tests
+  --node       Enable nodejs integration for electron
+  --sandbox    Enable electron sandbox                                                                                   [default: true]
+  --basedir    Set this if you need to require node modules in node mode
+  --help       Print usage instructions
 ```
 
 ...or any of the [other options you can pass to browser-run](https://github.com/juliangruber/browser-run#runopts).

diff --git a/bin/run.js b/bin/run.js
@@ -34,6 +34,10 @@ var argv = optimist
   .alias('node-integration', 'node')
   .alias('nodeIntegration', 'node')
 
+  .describe('sandbox', 'Enable electron sandbox')
+  .boolean('sandbox')
+  .default('sandbox', true)
+
   .describe('basedir', 'Set this if you need to require node modules in node mode')
 
   .describe('help', 'Print usage instructions')

diff --git a/package.json b/package.json
@@ -16,7 +16,7 @@
   },
   "dependencies": {
     "@juliangruber/tap-finished": "0.0.2",
-    "browser-run": "^8.0.0",
+    "browser-run": "^10.1.0",
     "optimist": "~0.6.1",
     "through": "~2.3.4",
     "throughout": "0.0.0"