[Tests] add test case for #519 for test.comment() in createStream/objectMode context #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectMode context
ljharb
approved these changes
May 25, 2020
ljharb
changed the title
|
OK, thanks! Out of curiosity, how should I have linked it to the issue? |
|
Just referencing it with |
|
I put “fixes ###” in the commit message and it did show up in the issue timeline. No worries here, just wanted to be sure I was doing things right. |
|
ah, you're right! however, a commit reference in the timeline is unfortunately a lot more subtle than a PR reference, so i missed it :-/ |
|
Got it. I’ll be more explicit in the future! |
ljharb
added a commit
that referenced
this pull request
Dec 29, 2020
- [New] Include name of test in log when test times out (#524) - [readme] document Promise support; remove Promise-related alternatives - [readme] add `tape-describe` to 'other' section (#523) - [Deps] update `deep-equal`, `is-regex`, `object-inspect`, `object-is`, `object.assign`, `resolve`, `string.prototype.trim` - [Dev Deps] update `eslint`, `js-yaml` - [eslint] remove useless regex escapes - [Tests] handle stack differences in node 15 - [Tests] add test case for #519 for test.comment() in createStream/objectMode context (#520)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.