This repository has been archived by the owner on Sep 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Closes #19
Thanks for the thorough explanation, @isaacs , my solution was to simply emit any cached single line assert result, or if not followed by yamlish starting line, before parsing (respectively emitting) anything else.
Then I changed the position of all of the
assert
events for single assert lines one by one by hand, just to make sure the logic is correct (excepttap-tests-stdout
andtap-tests
that I generated). So even if you don't like my solution, you can still pick the tests fix commit and test your solution against that, because this is the correct event order anyway.