Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark expelled instances as left #2290

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Mark expelled instances as left #2290

wants to merge 1 commit into from

Conversation

yngvar-antonsson
Copy link
Collaborator

@yngvar-antonsson yngvar-antonsson commented Dec 19, 2024

To be merged after tarantool/membership#68

This pull request includes updates to the CHANGELOG.rst file and improvements to the cartridge/confapplier.lua file to handle expelled instances more effectively. The most important changes are summarized below:

Changelog Updates:

  • Added a new section under "Fixed" to document that expelled instances are now marked as "left" in membership.

Codebase Improvements:

  • Added a membership module requirement in cartridge/confapplier.lua to utilize its functionalities.
  • Updated the apply_config function to mark expelled instances as "left" using the membership.mark_left method.

I didn't forget about

  • Changelog

@yngvar-antonsson yngvar-antonsson added the do not merge Not ready to be merged label Dec 19, 2024
@yngvar-antonsson yngvar-antonsson marked this pull request as draft December 19, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant