Fix box.ctl.promote error handling #2291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving error handling and logging in the
cartridge/failover.lua
file. The most important changes include ensuring that errors frombox.ctl.promote
andbox.ctl.demote
are properly logged and handled, and that theraft_failover.disable
function handles errors correctly.Improved error handling and logging:
cartridge/failover.lua
: Changed thesynchro_promote
andsynchro_demote
functions to usepcall
for error handling and added logging for errors. [1] [2]cartridge/failover.lua
: Updated thereconfigure_all
function to handle errors fromsynchro_promote
by raising an error ifsynchro_promote
fails.cartridge/failover.lua
: Modified thecfg
function to handle errors fromsynchro_promote
,synchro_demote
, andraft_failover.disable
by raisingApplyConfigError
if any of these functions fail. [1] [2] [3]cartridge/failover/raft.lua
: Updated thedisable
function to usepcall
for error handling and added logging for errors.Documentation:
CHANGELOG.rst
: Added a note indicating that errors frombox.ctl.promote
andbox.ctl.demote
are now logged.I didn't forget about