Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] Seems that error can be ignored in some cases of crud.select #144

Closed
filonenko-mikhail opened this issue Apr 7, 2021 · 0 comments · Fixed by #180
Closed

[1pt] Seems that error can be ignored in some cases of crud.select #144

filonenko-mikhail opened this issue Apr 7, 2021 · 0 comments · Fixed by #180
Assignees
Labels
bug Something isn't working

Comments

@filonenko-mikhail
Copy link

There is tuple iteration
And here we first check tuple and than error.

https://github.com/tarantool/crud/blob/master/crud/select/compat/select_old.lua#L211

In other places it's done better way:

        local tuple, err = iter:get()
        if err ~= nil then
            return nil, SelectError:new("Failed to get next object: %s", err)
        end

        if tuple == nil then
            break
        end
@Totktonada Totktonada added the bug Something isn't working label Jun 18, 2021
@Totktonada Totktonada changed the title Seems that error can be ignored in some cases of crud.select [1pt] Seems that error can be ignored in some cases of crud.select Jul 2, 2021
mRrvz added a commit that referenced this issue Jul 5, 2021
receiving iterator is now called earlier than
checking tuple. Closes #144
@mRrvz mRrvz closed this as completed in #180 Jul 5, 2021
mRrvz added a commit that referenced this issue Jul 5, 2021
Checking error in the select_old module when
receiving iterator is now called earlier than
checking tuple. Closes #144
Totktonada added a commit that referenced this issue Oct 19, 2021
* Marked all changelog entries either with an issue ID or with a pull
  request ID.
* Added a changelog entry for #144 (ignoring of an error in
  `crud.pairs()`).
* Marked testing changes explicitly, move them down in the list.
Totktonada added a commit that referenced this issue Oct 19, 2021
* Marked all changelog entries either with an issue ID or with a pull
  request ID.
* Added a changelog entry for #144 (ignoring of an error in
  `crud.pairs()`).
* Marked testing changes explicitly, move them down in the list.
AnaNek pushed a commit that referenced this issue Nov 24, 2021
* Marked all changelog entries either with an issue ID or with a pull
  request ID.
* Added a changelog entry for #144 (ignoring of an error in
  `crud.pairs()`).
* Marked testing changes explicitly, move them down in the list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants