Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: jsonpath support #150

Merged
merged 4 commits into from
May 27, 2021
Merged

Select: jsonpath support #150

merged 4 commits into from
May 27, 2021

Conversation

mRrvz
Copy link
Contributor

@mRrvz mRrvz commented Apr 19, 2021 •
edited
Loading

Added jsonpath support for select. Part of #12

@mRrvz mRrvz marked this pull request as draft April 19, 2021 20:17
@mRrvz mRrvz marked this pull request as ready for review April 26, 2021 13:17
dokshina
dokshina reviewed Apr 26, 2021
View reviewed changes
crud/common/utils.lua Outdated Show resolved Hide resolved
crud/common/utils.lua Outdated Show resolved Hide resolved
crud/common/utils.lua Outdated Show resolved Hide resolved
crud/common/utils.lua Outdated Show resolved Hide resolved
crud/select/filters.lua Outdated Show resolved Hide resolved
test/integration/simple_operations_test.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed Apr 28, 2021
View reviewed changes
crud/common/utils.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed Apr 28, 2021
View reviewed changes
crud/select/filters.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed May 16, 2021
View reviewed changes
crud/common/utils.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed May 16, 2021
View reviewed changes
crud/common/utils.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed May 26, 2021
View reviewed changes
crud/common/utils.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed May 26, 2021
View reviewed changes
crud/select/executor.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed May 26, 2021
View reviewed changes
crud/select/filters.lua Outdated Show resolved Hide resolved
@mRrvz mRrvz marked this pull request as draft May 26, 2021 15:04
@mRrvz mRrvz marked this pull request as ready for review May 26, 2021 18:01
@mRrvz mRrvz requested review from olegrok and dokshina May 26, 2021 18:01
olegrok
olegrok approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch. LGTM.

Please change description of your PR - it doesn't "closes #12", it's only part of it.

dokshina
dokshina approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@dokshina dokshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch!

I am sure that we should update select examples in the doc. Of course, in a separated patch.

@mRrvz mRrvz merged commit 6021b72 into master May 27, 2021
@mRrvz mRrvz deleted the jsonpath-support branch May 27, 2021 11:15
This was referenced Nov 16, 2021
Merged
Merged
@ligurio ligurio mentioned this pull request Nov 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegrok olegrok olegrok approved these changes

@dokshina dokshina dokshina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mRrvz @olegrok @dokshina