Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: jsonpath indexes #158

Merged
merged 28 commits into from
Jun 22, 2021
Merged

Select: jsonpath indexes #158

merged 28 commits into from
Jun 22, 2021

Conversation

mRrvz
Copy link
Contributor

@mRrvz mRrvz commented May 26, 2021 •
edited
Loading

Added jsonpath indexes support for queries. Closes #12

@mRrvz mRrvz changed the title Jsonpath indexes Select: jsonpath indexes May 26, 2021
olegrok
olegrok reviewed May 27, 2021
View reviewed changes
Copy link
Contributor

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch. See several comments below.

crud/common/utils.lua Outdated Show resolved Hide resolved
crud/common/utils.lua Outdated Show resolved Hide resolved
crud/common/utils.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed Jun 17, 2021
View reviewed changes
crud/select/executor.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed Jun 17, 2021
View reviewed changes
crud/common/utils.lua Outdated Show resolved Hide resolved
@mRrvz mRrvz requested a review from olegrok June 17, 2021 18:31
olegrok
olegrok reviewed Jun 18, 2021
View reviewed changes
crud/common/utils.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed Jun 18, 2021
View reviewed changes
crud/common/utils.lua Outdated Show resolved Hide resolved
@olegrok
Copy link
Contributor

olegrok commented Jun 18, 2021

I suggest to rebase create some temporary branch based on https://github.com/tarantool/crud/tree/perf-test and verify your patch against performance degradation.

@mRrvz mRrvz requested a review from olegrok June 18, 2021 13:40
olegrok
olegrok reviewed Jun 18, 2021
View reviewed changes
crud/select/executor.lua Outdated Show resolved Hide resolved
@mRrvz mRrvz requested a review from olegrok June 18, 2021 17:03
olegrok
olegrok reviewed Jun 18, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
olegrok
olegrok reviewed Jun 18, 2021
View reviewed changes
crud/select/filters.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed Jun 21, 2021
View reviewed changes
Copy link
Contributor

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fixes. Consider last (I hope) comment below. And fix backward compatibility - I see that test for 1.10.6-1-g52c786b fails.

crud/select/filters.lua Show resolved Hide resolved
olegrok
olegrok reviewed Jun 21, 2021
View reviewed changes
crud/select.lua Outdated Show resolved Hide resolved
olegrok
olegrok reviewed Jun 21, 2021
View reviewed changes
crud/select/executor.lua Outdated Show resolved Hide resolved
olegrok
olegrok approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooooray! 🥇

Thanks for your patch. @dokshina take a look please.

dokshina
dokshina reviewed Jun 21, 2021
View reviewed changes
crud/select/executor.lua Outdated Show resolved Hide resolved
crud/select/executor.lua Outdated Show resolved Hide resolved
@mRrvz mRrvz requested a review from dokshina June 21, 2021 17:36
dokshina
dokshina approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@dokshina dokshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bless you! Thanks a lot for this patch.

dokshina
dokshina approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@dokshina dokshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bless you!

@dokshina dokshina merged commit 27d825f into master Jun 22, 2021
@dokshina dokshina deleted the jsonpath-indexes branch June 22, 2021 09:44
@mRrvz mRrvz mentioned this pull request Jul 5, 2021
Closed
ligurio added a commit that referenced this pull request Sep 3, 2021
@ligurio
Describe supported Tarantool versions with limitations
4071a64 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)

1. https://github.com/tarantool/tuple-keydef#compatibility
ligurio added a commit that referenced this pull request Sep 3, 2021
@ligurio
Describe supported Tarantool versions with limitations
066f8e5 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)

1. https://github.com/tarantool/tuple-keydef#compatibility
2.
https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
ligurio added a commit that referenced this pull request Sep 3, 2021
@ligurio
Describe supported Tarantool versions with limitations
b6854b7 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)

1. https://github.com/tarantool/tuple-keydef#compatibility
2.
https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
ligurio added a commit that referenced this pull request Sep 3, 2021
@ligurio
Describe supported Tarantool versions with limitations
8404b49 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)
- JSON paths support in Tarantool [3]

1. https://github.com/tarantool/tuple-keydef#compatibility
2.
https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/
ligurio added a commit that referenced this pull request Sep 3, 2021
@ligurio
Describe supported Tarantool versions with limitations
c53689f 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)
- JSON paths support in Tarantool [3]

1. https://github.com/tarantool/tuple-keydef#compatibility
2. https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/
ligurio added a commit that referenced this pull request Sep 3, 2021
@ligurio
Describe supported Tarantool versions with limitations
6f6ae50 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)
- JSON paths support in Tarantool [3]

1. https://github.com/tarantool/tuple-keydef#compatibility
2. https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/
ligurio added a commit that referenced this pull request Sep 6, 2021
@ligurio
Describe supported Tarantool versions with limitations
a2ef14d 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)
- JSON paths support in Tarantool [3]

1. https://github.com/tarantool/tuple-keydef#compatibility
2. https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/
ligurio added a commit that referenced this pull request Sep 6, 2021
@ligurio
Describe supported Tarantool versions with limitations
b4c592a 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)
- JSON paths support in Tarantool [3]
- release notes

1. https://github.com/tarantool/tuple-keydef#compatibility
2. https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/
4. https://www.tarantool.io/en/doc/latest/release/
ligurio added a commit that referenced this pull request Sep 6, 2021
@ligurio
Describe supported Tarantool versions with limitations
ed04684 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)
- JSON paths support in Tarantool [3]
- release notes

1. https://github.com/tarantool/tuple-keydef#compatibility
2. https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/
4. https://www.tarantool.io/en/doc/latest/release/
ligurio added a commit that referenced this pull request Sep 7, 2021
@ligurio
Describe supported Tarantool versions with limitations
c77247b 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)
- JSON paths support in Tarantool [3]
- release notes

1. https://github.com/tarantool/tuple-keydef#compatibility
2. https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/
4. https://www.tarantool.io/en/doc/latest/release/
ligurio added a commit that referenced this pull request Sep 10, 2021
@ligurio
Describe supported Tarantool versions with limitations
46999e4 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)
- JSON paths support in Tarantool [3]
- release notes

1. https://github.com/tarantool/tuple-keydef#compatibility
2. https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/
4. https://www.tarantool.io/en/doc/latest/release/
ligurio added a commit that referenced this pull request Sep 22, 2021
@ligurio
Describe supported Tarantool versions with limitations
140e7a5 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)
- JSON paths support in Tarantool [3]
- release notes

1. https://github.com/tarantool/tuple-keydef#compatibility
2. https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/
4. https://www.tarantool.io/en/doc/latest/release/
ligurio added a commit that referenced this pull request Sep 24, 2021
@ligurio
Describe supported Tarantool versions with limitations
4f51b25 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)
- JSON paths support in Tarantool [3]
- release notes

1. https://github.com/tarantool/tuple-keydef#compatibility
2. https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/
4. https://www.tarantool.io/en/doc/latest/release/
This was referenced Nov 14, 2021
Closed
Merged
Merged
@ligurio ligurio mentioned this pull request Nov 18, 2021
Open
ligurio added a commit that referenced this pull request Dec 6, 2021
@ligurio
Describe supported Tarantool versions with limitations
6202440 
For those who interested to dig to a topic himself I recommend to start
with:
- search using of helper functions like utils.tarantool_supports_* in
source code base
- search conditions with `_TARANTOOL` in source codebase
- supported Tarantool versions by tuple-keydef module [1]
- supported Tarantool versions by tuple-merger module [2]
- source code for compatibility layer in CRUD
- "Select: support jsonpath indexes (#158)" (27d825f)
- JSON paths support in Tarantool [3]
- release notes

1. https://github.com/tarantool/tuple-keydef#compatibility
2. https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees
3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/
4. https://www.tarantool.io/en/doc/latest/release/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegrok olegrok olegrok approved these changes

@dokshina dokshina dokshina approved these changes

@AnaNek AnaNek Awaiting requested review from AnaNek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2pt] Support JSON path
3 participants
@mRrvz @olegrok @dokshina