Number of fixes (typos, error names unification) #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mRrvz
reviewed
Jul 12, 2021
ligurio
force-pushed
the
ligurio/fixes
branch
2 times, most recently
from
b928ecc
to
543ce01
Compare
mRrvz
approved these changes
Jul 12, 2021
AnaNek
approved these changes
Jul 12, 2021
rosik
approved these changes
Jul 12, 2021
Totktonada
reviewed
Jul 13, 2021
Totktonada
reviewed
Jul 13, 2021
Merged
ligurio
force-pushed
the
ligurio/fixes
branch
9 times, most recently
from
142624f
to
c717aa4
Compare
olegrok
reviewed
Jul 16, 2021
README.md
Outdated
| @@ -66,7 +66,7 @@ local result, err = crud.insert_object(space_name, object, opts) | |||
|
|
|||
| where: | |||
|
|
|||
| * `space_name` (`string`) - name of the space to insert an object | |||
| * `space_name` (`string|number`) - name or numerical id of the space to insert an object | |||
There was a problem hiding this comment.
Is it tested anyhow?
Won't it be a problem because on different replicasets the same space could have different id?
There was a problem hiding this comment.
No actually, I have reverted these changes.
Totktonada
approved these changes
Jul 26, 2021
|
Please, update the CHANGELOG. |
olegrok
approved these changes
Jul 26, 2021
We use `errors.new_class()` that declares error names. Error names usually has a form "<OperationName>Error", but some error codes has a form "<OperationName>". This patch makes all error names conform to the first form.
|
@mRrvz Updated. |
mRrvz
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE MERGE IT WITH REBASE (without squash)
What has been done? Why? What problem is being solved?
I didn't forget about
Closes #???