-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
box.atomic tnx_isolation #3593
box.atomic tnx_isolation #3593
Conversation
143218c
to
7afe03e
Compare
550f32b
to
b4e8eb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments from my side.
Otherwise LGTM 👍
:param table opts: (optional) transaction options: | ||
|
||
* ``txn_isolation`` -- the :ref:`transaction isolation level <txn_mode_mvcc-options>` | ||
* ``timeout`` -- a timeout (in seconds), after which the transactions are rolled back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the transactions" confuses a bit. Maybe use singular?
|
||
:param function-arguments: (optional) arguments passed to the function | ||
|
||
:return: the result of the function passed to ``atomic()`` as an argument | ||
|
||
**Possible errors:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add the "timeout exceeded" error?
b4e8eb0
to
030b838
Compare
030b838
to
dcf8b1c
Compare
opts
parameter to the box.atomic() function and updated the example to show how to specify the isolation level.txn_isolation
and added thetimeout
parameter.