Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add space.stat() and tuple.info() reference #4373

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Add space.stat() and tuple.info() reference #4373

merged 4 commits into from
Jul 23, 2024

Conversation

p7nov
Copy link
Contributor

@p7nov p7nov commented Jul 19, 2024 •
edited
Loading

@p7nov p7nov requested a review from Gumix July 19, 2024 07:45
@p7nov p7nov changed the title Add space.stat and tuple.info reference Add space.stat() and tuple.info() reference Jul 19, 2024
Gumix
Gumix reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@Gumix Gumix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a note that waste_size is not accurate. It is provided for reference only and shouldn't be used for memory usage calculations.

@p7nov p7nov requested a review from xuniq July 22, 2024 04:00
xuniq
xuniq approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@xuniq xuniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also suggest adding the links to tuple:info() and space:stat() to the corresponding What's New section

@p7nov p7nov linked an issue Jul 23, 2024 that may be closed by this pull request
Document tuple:info() #3840
Closed
@p7nov p7nov merged commit 70493eb into latest Jul 23, 2024
1 check passed
@p7nov p7nov deleted the gh-3841-space-stat branch July 23, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gumix Gumix Gumix left review comments

@xuniq xuniq xuniq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document space:stat() Document tuple:info()
3 participants
@p7nov @Gumix @xuniq