Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove box.info.cluster.uuid usage from tests #293

Closed
sergepetrenko opened this issue May 18, 2023 · 2 comments · Fixed by #294
Closed

Remove box.info.cluster.uuid usage from tests #293

sergepetrenko opened this issue May 18, 2023 · 2 comments · Fixed by #294
Assignees
@oleg-jukovec
Labels
bug Something isn't working teamE

Comments

@sergepetrenko
Copy link

go-tarantool integration tests fail on one of the Tarantool 3.0 PRs: tarantool/tarantool#8289 https://github.com/tarantool/tarantool/actions/runs/5011819703/jobs/8984720081?pr=8289

The reason seems to be in ./crud/testdata/config.lua referencing box.info().cluster.uuid.
The tarantool/tarantool#8289 PR renames box.info.cluster.uuid to box.info.replicaset.uuid.

So the test should prefer box.info.replicaset.uuid and only fall back to box.info.cluster.uuid if box.info.replicaset.uuid is missing.
@sergepetrenko sergepetrenko changed the title Fix tests for Tarantool 3.0 Remove box.info.cluster.uuid usage from tests May 18, 2023
@oleg-jukovec oleg-jukovec added teamE bug Something isn't working labels May 18, 2023
@oleg-jukovec oleg-jukovec self-assigned this May 18, 2023
oleg-jukovec added a commit that referenced this issue May 18, 2023
@oleg-jukovec
test: try to use box.info.replication.uuid
3fed8ed 
We need use `box.info.replication.uuid` instead of
`box.info.cluster.uuid` to support Tarantool 3.0.

Part of #293
@oleg-jukovec
Copy link
Collaborator

oleg-jukovec commented May 18, 2023 •
edited
Loading

We also need to wait for vshard->crud fixes and bump the crud version:

2023-05-18 16:24:24.563 [43984] main/103/config.lua/testdata.vshard.storage I> Starting configuration of replica 6d3e787a-92f7-4386-8fa4-165d94b28342
2023-05-18 16:24:24.563 [43984] main/103/config.lua/testdata.vshard.storage I> I am master
2023-05-18 16:24:24.563 [43984] main/103/config.lua/testdata.vshard.storage I> Taking on replicaset master role...
2023-05-18 16:24:24.563 [43984] main utils.c:610 E> LuajitError: .../testdata/.rocks/share/tarantool/vshard/storage/init.lua:3491: .../testdata/.rocks/share/tarantool/vshard/storage/init.lua:3404: Replicaset UUID mismatch: already set "nil" but "1f8e45ab-c856-42e4-b6a3-7ec23135eb2d" in vshard config
2023-05-18 16:24:24.563 [43984] main F> fatal error, exiting the event loop

oleg-jukovec added a commit that referenced this issue May 18, 2023
@oleg-jukovec
test: fix compatibility with Tarantool master
2642732 
We need use `box.info.replication.uuid` instead of
`box.info.cluster.uuid` to support Tarantool 3.0.

Part of #293
@LeonidVas LeonidVas added blocked Not ready to be implemented and removed blocked Not ready to be implemented labels May 18, 2023
@oleg-jukovec oleg-jukovec mentioned this issue May 18, 2023
Merged
1 task
@Serpentian
Copy link

Vshard's fixes are in master now

oleg-jukovec added a commit that referenced this issue May 19, 2023
@oleg-jukovec
test: fix compatibility with Tarantool master
a57a063 
We need use `box.info.replication.uuid` instead of
`box.info.cluster.uuid` to support Tarantool 3.0.

Closes #293
oleg-jukovec added a commit that referenced this issue May 19, 2023
@oleg-jukovec
test: fix compatibility with Tarantool master
ab957c4 
We need use `box.info.replication.uuid` instead of
`box.info.cluster.uuid` to support Tarantool 3.0.

Closes #293
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
Release 1.12.0
59a709b 
Overview

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
Release 1.12.0
9fb0943 
Overview

The release introduces the ability to gracefully close Connection
and ConnectionPool and also provides methods for adding or removing
an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
Release 1.12.0
238562f 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
@oleg-jukovec oleg-jukovec mentioned this issue May 29, 2023
Merged
oleg-jukovec added a commit that referenced this issue Jun 6, 2023
@oleg-jukovec
Release 1.12.0
5fff2f0 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue Jun 7, 2023
@oleg-jukovec
Release 1.12.0
1d2d5cd 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue Jun 7, 2023
@oleg-jukovec
Release 1.12.0
403f2c3 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleg-jukovec oleg-jukovec

Labels
bug Something isn't working teamE
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix compatibility with Tarantool master tarantool/go-tarantool
4 participants
@oleg-jukovec @sergepetrenko @LeonidVas @Serpentian