bugfix: allow multiple Future.Get*() #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/gettyped-after-get
branch
from
8e81a4d
to
848a615
Compare
vr009
approved these changes
Sep 9, 2022
oleg-jukovec
requested review from
DifferentialOrange
and removed request for
AnaNek
oleg-jukovec
force-pushed
the
oleg-jukovec/gettyped-after-get
branch
from
848a615
to
a07b3a9
Compare
After the patch, a user can call Future.GetTyped() or Future.Get() multiple times in any order. Needed for tarantool/tt#54
oleg-jukovec
force-pushed
the
oleg-jukovec/gettyped-after-get
branch
from
a07b3a9
to
fc20be0
Compare
oleg-jukovec
changed the title
DifferentialOrange
approved these changes
Sep 21, 2022
oleg-jukovec
added a commit
that referenced
this pull request
Oct 4, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178)
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176)
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176)
An example how to use queue and connection_pool subpackages
together (#176)
Bugfixes
Mode type description in the connection_pool subpackage (#208)
Missed Role type constants in the connection_pool subpackage (#208)
ConnectionPool does not close UnknownRole connections (#208)
Segmentation faults in ConnectionPool requests after
disconnect (#208)
Addresses in ConnectionPool may be changed from an external
code (#208)
ConnectionPool recreates connections too often (#208)
A connection is still opened after ConnectionPool.Close() (#208)
Future.GetTyped() after Future.Get() does not decode response
correctly (#213)
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219)
Datetime location after encode + decode is unequal (#217)
oleg-jukovec
added a commit
that referenced
this pull request
Oct 4, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
Merged
oleg-jukovec
added a commit
that referenced
this pull request
Oct 5, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
oleg-jukovec
added a commit
that referenced
this pull request
Oct 31, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
Wrong interval arithmetic with timezones (#221).
Invalid MsgPack if STREAM_ID > 127 (#224).
queue.Take() returns an invalid task (#222).
oleg-jukovec
added a commit
that referenced
this pull request
Oct 31, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
Wrong interval arithmetic with timezones (#221).
Invalid MsgPack if STREAM_ID > 127 (#224).
queue.Take() returns an invalid task (#222).
oleg-jukovec
added a commit
that referenced
this pull request
Nov 2, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
Wrong interval arithmetic with timezones (#221).
Invalid MsgPack if STREAM_ID > 127 (#224).
queue.Take() returns an invalid task (#222).
oleg-jukovec
added a commit
that referenced
this pull request
Nov 2, 2022
Overview
The release adds support for the latest version of the
queue package with master-replica switching.
Breaking changes
There are no breaking changes in the release.
New features
Support the queue 1.2.1 (#177).
ConnectionHandler interface for handling changes of connections in
ConnectionPool (#178).
Execute, ExecuteTyped and ExecuteAsync methods to
ConnectionPool (#176).
ConnectorAdapter type to use ConnectionPool as Connector
interface (#176).
An example how to use queue and connection_pool subpackages
together (#176).
Bugfixes
Mode type description in the connection_pool subpackage (#208).
Missed Role type constants in the connection_pool
subpackage (#208).
ConnectionPool does not close UnknownRole connections (#208).
Segmentation faults in ConnectionPool requests after
disconnect (#208).
Addresses in ConnectionPool may be changed from an external
code (#208).
ConnectionPool recreates connections too often (#208).
A connection is still opened after ConnectionPool.Close() (#208).
Future.GetTyped() after Future.Get() does not decode response
correctly (#213).
Decimal package use a test function GetNumberLength instead of a
package-level function getNumberLength (#219).
Datetime location after encode + decode is unequal (#217).
Wrong interval arithmetic with timezones (#221).
Invalid MsgPack if STREAM_ID > 127 (#224).
queue.Take() returns an invalid task (#222).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the patch, a user can call Future.GetTyped() or Future.Get() multiple times in any order.
I didn't forget about (remove if it is not applicable):
Related issues:
Needed for tarantool/tt#54