pool: fix race condition at GetNextConnection() #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-309-round-robin-race
branch
from
d729c97
to
1708f5b
Compare
oleg-jukovec
requested review from
better0fdead
and removed request for
DifferentialOrange
DifferentialOrange
approved these changes
Jun 28, 2023
oleg-jukovec
changed the title
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-309-round-robin-race
branch
from
1708f5b
to
eaf2321
Compare
oleg-jukovec
changed the title
The `r.current` value can be changed by concurrent threads because the change happens under read-lock. We could use the atomic counter for a current connection number to avoid the race condition. Closes #309
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-309-round-robin-race
branch
from
eaf2321
to
3e77a2f
Compare
better0fdead
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
r.currentvalue can be changed by concurrent threads because the change happens under read-lock. We could use the atomic counter for a current connection number to avoid the race condition.I didn't forget about (remove if it is not applicable):
Related issues:
Closes #309