Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool: get instance status from WatchOnce request #386

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

DerekBum
Copy link

@DerekBum DerekBum commented Mar 5, 2024

Starting from Tarantool version >= 3.0.0 WatchOnce requset is supported. So we can get instance status using this request instead of calling box.info.

This way user can add instances to the ConnectionPool without the execute access.

I didn't forget about (remove if it is not applicable):

Related issues:
Closes #380

@DerekBum DerekBum force-pushed the DerekBum/gh-380-get-status-from-watch-once branch 2 times, most recently from 31c67c6 to 1ed61f7 Compare March 5, 2024 13:07
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just few notes.

CHANGELOG.md Outdated Show resolved Hide resolved
pool/config.lua Outdated Show resolved Hide resolved
pool/connection_pool_test.go Outdated Show resolved Hide resolved
pool/connection_pool_test.go Outdated Show resolved Hide resolved
pool/connection_pool_test.go Outdated Show resolved Hide resolved
pool/connection_pool_test.go Show resolved Hide resolved
@DerekBum DerekBum force-pushed the DerekBum/gh-380-get-status-from-watch-once branch from 1ed61f7 to 51e634a Compare March 5, 2024 13:46
Starting from Tarantool version >= 3.0.0 `WatchOnce` requset is
supported. So we can get instance status using this request instead
of calling `box.info`.

This way user can add instances to the ConnectionPool without the
`execute` access.

Closes #380
@DerekBum DerekBum force-pushed the DerekBum/gh-380-get-status-from-watch-once branch from 51e634a to 136ef5d Compare March 5, 2024 13:49
Copy link

@better0fdead better0fdead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thx for patch

@oleg-jukovec oleg-jukovec merged commit dc1fe5d into master Mar 6, 2024
26 checks passed
@oleg-jukovec oleg-jukovec deleted the DerekBum/gh-380-get-status-from-watch-once branch March 6, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pool: get status of an instance via WATCH_ONCE
3 participants