test: use coverage instead of equality to test error payload #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshy
force-pushed
the
nshi/fix-error-payload-tests
branch
2 times, most recently
from
8dffb1e
to
24f3774
Compare
In this version (latest currently) require.Subset supports maps correctly. Also it has the feature documented.
We are going to add missing 'user' payload field for ACCESS_DENIED error which will break current tests. Let fix tests to allow adding new payload fields for errors. Need for tarantool/tarantool#9108
nshy
force-pushed
the
nshi/fix-error-payload-tests
branch
from
24f3774
to
7ac1cd9
Compare
oleg-jukovec
approved these changes
Mar 29, 2024
|
Thank you for the patch! At the first glance it seems like it would be better to check different fields for different versions of Tarantool. But on the other hand, there may be too many |
|
Thanx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to add missing 'user' payload field for ACCESS_DENIED error which will break current tests. Let fix tests to allow adding new payload fields for errors.
Need for tarantool/tarantool#9108