Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-tlsdialer: initial repository setup #1

Merged
merged 3 commits into from
Feb 8, 2024
Merged

go-tlsdialer: initial repository setup #1

merged 3 commits into from
Feb 8, 2024

Conversation

DerekBum
Copy link
Contributor

@DerekBum DerekBum commented Jan 31, 2024 •
edited
Loading

To disable SSL by default we want to transfer OpenSSLDialer and any other SSL logic to the new go-tlsdialer repository.

go-tlsdialer serves as an interlayer between go-tarantool and go-openssl. All SSL logic from go-tarantool is moved to the go-tlsdialer.

go-tlsdialer still uses tarantool connection, but also types and methods from go-openssl. This way we are removing the direct go-openssl dependency from go-tarantool, without creating a tarantool dependency in go-openssl.

Moved all SSL code from go-tarantool, some test helpers. Added README.md, ci workflow.

Part of tarantool/go-tarantool#301

@DerekBum
Copy link
Contributor Author

For the most part, code copied here will be deleted from the go-tarantool repo. However, there is the list of the parts, that will be in both repositories:

  1. writeFlusher interface.
  2. deadlineIO type and its methods.
  3. parseAddress function.
  4. Some of the test helpers in the ssl_test.go.

oleg-jukovec
oleg-jukovec reviewed Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, split the commit into commits:

  • CI
  • README
  • Implementation

Let's also add:

  • example_test.go file with a short example.
  • CHANGELOG.md with a shot description of the changes.

You could although remove all ssl* prefixes at now.

.github/workflows/testing.yml Outdated Show resolved Hide resolved
.golangci.yaml Outdated Show resolved Hide resolved
.luacheckrc Outdated Show resolved Hide resolved
.github/workflows/testing.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ssl_opts.go Outdated Show resolved Hide resolved
tarantool_test.go Outdated Show resolved Hide resolved
tarantool_test.go Outdated Show resolved Hide resolved
testdata/sidecar/main Outdated Show resolved Hide resolved
ssl_test.go Outdated Show resolved Hide resolved
@DerekBum DerekBum force-pushed the DerekBum/no-gh-initial-repo-setup branch 18 times, most recently from c893be8 to c760caa Compare February 2, 2024 14:00
oleg-jukovec
oleg-jukovec approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

README.md Outdated Show resolved Hide resolved
dial.go Outdated Show resolved Hide resolved
dial.go Outdated Show resolved Hide resolved
example_test.go Outdated Show resolved Hide resolved
testdata/config.lua Outdated Show resolved Hide resolved
testdata/sidecar/main.go Outdated Show resolved Hide resolved
dialer_test.go Outdated Show resolved Hide resolved
dialer_test.go Outdated Show resolved Hide resolved
@DerekBum DerekBum force-pushed the DerekBum/no-gh-initial-repo-setup branch 5 times, most recently from 405f439 to 927312d Compare February 2, 2024 16:12
@DerekBum
Copy link
Contributor Author

DerekBum commented Feb 2, 2024

Fixed everything from the previous comments.

oleg-jukovec
oleg-jukovec reviewed Feb 4, 2024
View reviewed changes
deadline_io.go Outdated Show resolved Hide resolved
oleg-jukovec
oleg-jukovec reviewed Feb 4, 2024
View reviewed changes
deadline_io.go Outdated Show resolved Hide resolved
@DerekBum
ci: setup ci workflow
e141d1d 
In this commit the ci workflow is created for the repository.
@DerekBum
docs: create a README file
24f76a6 
In thes commit `README.md` and `CHANGELOG.md` files are created.
`README` shows the purpose of this repository.
@DerekBum DerekBum force-pushed the DerekBum/no-gh-initial-repo-setup branch from 927312d to 94b6063 Compare February 4, 2024 14:07
DifferentialOrange
DifferentialOrange reviewed Feb 5, 2024
View reviewed changes
.github/workflows/testing.yml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
conn.go Outdated Show resolved Hide resolved
conn.go Show resolved Hide resolved
@DerekBum DerekBum force-pushed the DerekBum/no-gh-initial-repo-setup branch 7 times, most recently from 46c4ac4 to 4432335 Compare February 7, 2024 15:23
@DerekBum
Copy link
Contributor Author

DerekBum commented Feb 7, 2024

Updated the README, now it includes instructions about the application build (static and dynamic).

oleg-jukovec
oleg-jukovec approved these changes Feb 7, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
dialer.go Outdated Show resolved Hide resolved
@DerekBum DerekBum force-pushed the DerekBum/no-gh-initial-repo-setup branch 2 times, most recently from 568f588 to a0c30c2 Compare February 7, 2024 17:49
@DerekBum
api: add OpenSSLDialer implementation
4c19642 
To disable SSL by default we want to transfer OpenSSLDialer
and any other SSL logic to the new go-tlsdialer repository.

go-tlsdialer serves as an interlayer between go-tarantool and
go-openssl. All SSL logic from go-tarantool is moved to the
go-tlsdialer.

go-tlsdialer still uses tarantool connection, but also
types and methods from go-openssl. This way we are
removing the direct go-openssl dependency from go-tarantool,
without creating a tarantool dependency in go-openssl.

Moved all SSL code from go-tarantool, some test helpers.

Part of tarantool/go-tarantool#301
@DerekBum DerekBum force-pushed the DerekBum/no-gh-initial-repo-setup branch from a0c30c2 to 4c19642 Compare February 7, 2024 17:51
@oleg-jukovec oleg-jukovec merged commit e2caece into master Feb 8, 2024
18 checks passed
@oleg-jukovec oleg-jukovec deleted the DerekBum/no-gh-initial-repo-setup branch February 8, 2024 07:05
oleg-jukovec added a commit that referenced this pull request Feb 9, 2024
@oleg-jukovec
Release 1.0.0
19f4be2 
Overview

    The first release of the library allows us to extract the dependency on
    OpenSSL from the connector go-tarantool[1].

New features

    `OpenSSLDialer` type to use SSL transport for `tarantool/go-tarantool/v2`
    connection (#1).

1. https://pkg.go.dev/github.com/tarantool/go-tarantool/v2
@oleg-jukovec oleg-jukovec mentioned this pull request Feb 9, 2024
Merged
oleg-jukovec added a commit that referenced this pull request Feb 12, 2024
@oleg-jukovec
Release 1.0.0
04acc8a 
Overview

    The first release of the library allows us to extract the dependency on
    OpenSSL from the connector go-tarantool[1].

New features

    `OpenSSLDialer` type to use SSL transport for `tarantool/go-tarantool/v2`
    connection (#1).

1. https://pkg.go.dev/github.com/tarantool/go-tarantool/v2
oleg-jukovec added a commit that referenced this pull request Feb 12, 2024
@oleg-jukovec
Release 1.0.0
662f793 
Overview

    The first release of the library allows us to extract the
    dependency on OpenSSL from the connector go-tarantool[1].

New features

    `OpenSSLDialer` type to use SSL transport for
    `tarantool/go-tarantool/v2` connection (#1).

1. https://pkg.go.dev/github.com/tarantool/go-tarantool/v2
oleg-jukovec added a commit that referenced this pull request Feb 12, 2024
@oleg-jukovec
Release 1.0.0
671a1ba 
Overview

    The first release of the library allows us to extract the
    dependency on OpenSSL from the connector go-tarantool[1].

New features

    `OpenSSLDialer` type to use SSL transport for
    `tarantool/go-tarantool/v2` connection (#1).

1. https://pkg.go.dev/github.com/tarantool/go-tarantool/v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DifferentialOrange DifferentialOrange DifferentialOrange approved these changes

@oleg-jukovec oleg-jukovec oleg-jukovec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DerekBum @DifferentialOrange @oleg-jukovec