New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new _index system space format #151

Closed

Totktonada opened this issue Mar 17, 2020 · 0 comments · Fixed by #164

Assignees

Labels

feature

Milestone

PHP 7.* + bugfixes

Member

Totktonada commented Mar 17, 2020

After tarantool-1.7.5-153-g1651fc9be the new _index format was introduced. We should support it to fetch a schema from a tarantool-1.7.5.153+ instance.

When an index parts do not use parameters except name and type the index info is stored in the old format in _index system space and the connector works. When an index part uses is_nullable or collation parameter, the the new format will be used and the connector will not work (will fail on schema fetching as in #127).

All system spaces except _func uses the old _index format. The _func system space has a secondary index with unicode_ci collation on several tarantool versions:

Neither of 2.1 and below.
All 2.2.* since 2.2.0-558-g200a492aa (inclusive).
All 2.3.* until 2.3.0-259-gf88f9731a (exclusive).
Neither of 2.4.*.

However if a user defines a space with an index with is_nullable or collation index part parameters, then, again, the schema fetching will not work.

The text was updated successfully, but these errors were encountered:

Totktonada added the feature label

Totktonada added a commit that referenced this issue


          travis-ci: temporary reduce testing (php 7.0 only)

248c46d

Temporary disabled php 7.1+ and RPM/Deb packages to get working tests on
php 7.0 first.

Added testing against different tarantool versions.

Temporary disabled tarantool-2.2 testing due to lack of support of the
new schema format (see #151).

Totktonada added a commit that referenced this issue


          travis-ci: temporary reduce testing (php 7.0 only)

4f6ecd4

Temporary disabled php 7.1+ and RPM/Deb packages to get working tests on
php 7.0 first.

Added testing against different tarantool versions.

Temporary disabled tarantool-2.2 testing due to lack of support of the
new schema format (see #151).

Totktonada added a commit that referenced this issue


          travis-ci: temporary reduce testing (php 7.0 only)

d1fc1fb

Temporary disabled php 7.1+ and RPM/Deb packages to get working tests on
php 7.0 first.

Added testing against different tarantool versions.

Temporary disabled tarantool-2.2 testing due to lack of support of the
new schema format (see #151).

Totktonada mentioned this issue

Failed to parse schema (index) #127

Closed

Totktonada added this to the PHP 7.* + bugfixes milestone

Totktonada added a commit that referenced this issue


          travis-ci: temporary reduce testing (php 7.0 only)

10567b9

Temporary disabled php 7.1+ and RPM/Deb packages to get working tests on
php 7.0 first.

Added testing against different tarantool versions.

Temporary disabled tarantool-2.2 testing due to lack of support of the
new schema format (see #151).

Totktonada assigned LeonidVas

LeonidVas added a commit that referenced this issue


          move decoding index parts to a separate function

b53b13c

To simplify adding further changes, move decoding index parts to
a separate function and update it in accordance with the decoding
function from tarantool.

Part of #151

LeonidVas added a commit that referenced this issue


          add collation and is_nullable opts

cf264b6

Add collation and is_nullable opts to schema_field_value.

Part of #151

LeonidVas added a commit that referenced this issue


          update processing the field type

bc0fa04

Update processing the field type in accordance with the same in tarantool.

Part of #151

LeonidVas added a commit that referenced this issue


          add support new _index system space format

a4def4d

After tarantool-1.7.5-153-g1651fc9be the new _index format was
introduced. We should support it to fetch a schema from
a tarantool-1.7.5.153+ instance.
When an index parts do not use parameters except name and type
the index info is stored in the old format in _index system space.
When an index part uses is_nullable or collation parameter, then
the new format will be used.

Close #151

LeonidVas linked a pull request

that will close this issue

Support new _index format #164

Merged

LeonidVas added a commit that referenced this issue


          refactoring: move decoding index parts to a separate function

bc5b1ae

To simplify adding further changes, move decoding index parts to
a separate function and update it in accordance with the decoding
function from tarantool.

Part of #151

LeonidVas added a commit that referenced this issue


          schema: add collation and is_nullable opts

fe0d488

Add collation and is_nullable opts to schema_field_value.

Part of #151

LeonidVas added a commit that referenced this issue


          schema: update processing the field type

630b6e1

Update processing the field type in accordance with the same in tarantool.

Part of #151

LeonidVas added a commit that referenced this issue


          schema: add support new _index system space format

7a60f69

After tarantool-1.7.5-153-g1651fc9be the new _index format was
introduced. We should support it to fetch a schema from
a tarantool-1.7.5.153+ instance.
When an index parts do not use parameters except name and type
the index info is stored in the old format in _index system space.
When an index part uses is_nullable or collation parameter, then
the new format will be used.

Close #151

LeonidVas added a commit that referenced this issue


          schema: update processing the field type

347281f

Update processing the field type in accordance with the same in tarantool.

Part of #151

LeonidVas added a commit that referenced this issue


          schema: add support new _index system space format

20a62e1

After tarantool-1.7.5-153-g1651fc9be the new _index format was
introduced. We should support it to fetch a schema from
a tarantool-1.7.5.153+ instance.
When an index parts do not use parameters except name and type
the index info is stored in the old format in _index system space.
When an index part uses is_nullable or collation parameter, then
the new format will be used.

Close #151

LeonidVas added a commit that referenced this issue


          schema: add support new _index system space format

a9f266e

After tarantool-1.7.5-153-g1651fc9be the new _index format was
introduced. We should support it to fetch a schema from
a tarantool-1.7.5.153+ instance.
When an index parts do not use parameters except name and type
the index info is stored in the old format in _index system space.
When an index part uses is_nullable or collation parameter, then
the new format will be used.

Close #151

LeonidVas added a commit that referenced this issue


          refactoring: move decoding index parts to a separate function

471e061

To simplify adding further changes, move decoding index parts to
a separate function and update it in accordance with the decoding
function from tarantool.

Part of #151

LeonidVas added a commit that referenced this issue


          schema: add collation and is_nullable opts

4d4e4d9

Add collation and is_nullable opts to schema_field_value.

Part of #151

LeonidVas added a commit that referenced this issue


          schema: update processing the field type

c2a464e

Update processing the field type in accordance with the same in tarantool.

Part of #151

LeonidVas added a commit that referenced this issue


          schema: add support new _index system space format

acdfa0f

After tarantool-1.7.5-153-g1651fc9be the new _index format was
introduced. We should support it to fetch a schema from
a tarantool-1.7.5.153+ instance.
When an index parts do not use parameters except name and type
the index info is stored in the old format in _index system space.
When an index part uses is_nullable or collation parameter, then
the new format will be used.

Close #151

LeonidVas added a commit that referenced this issue


          schema: add support new _index system space format

746e42d

After tarantool-1.7.5-153-g1651fc9be the new _index format was
introduced. We should support it to fetch a schema from
a tarantool-1.7.5.153+ instance.
When an index parts do not use parameters except name and type
the index info is stored in the old format in _index system space.
When an index part uses is_nullable or collation parameter, then
the new format will be used.

Close #151

LeonidVas mentioned this issue

Support new _index format #164

Merged

Totktonada closed this as completed in #164

Totktonada pushed a commit that referenced this issue


          refactoring: move decoding index parts to a separate function

d1bdb6c

To simplify adding further changes, move decoding index parts to
a separate function and update it in accordance with the decoding
function from tarantool.

Part of #151

Totktonada pushed a commit that referenced this issue


          schema: add collation and is_nullable opts

dc7523f

Add collation and is_nullable opts to schema_field_value.

Part of #151

Totktonada pushed a commit that referenced this issue


          schema: update processing the field type

4c076ef

Update processing the field type in accordance with the same in tarantool.

Part of #151

Totktonada pushed a commit that referenced this issue


          schema: add support new _index system space format

8539a7f

After tarantool-1.7.5-153-g1651fc9be the new _index format was
introduced. We should support it to fetch a schema from
a tarantool-1.7.5.153+ instance.
When an index parts do not use parameters except name and type
the index info is stored in the old format in _index system space.
When an index part uses is_nullable or collation parameter, then
the new format will be used.

Close #151

oleg-jukovec mentioned this issue

Release 0.4.0 #176

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment