-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An exception occurs while trying to disable connection retries #83
Comments
This commit changes meanging of the `retry_count` option: now it means amount of attempts to connect after the first one, not overall attempts count. Closes tarantool#83
This commit changes meanging of the `retry_count` option: now it means amount of attempts to connect after the first one, not overall attempts count. Closes tarantool#83
Now
So
I'm not sure whether we should change meaning of the option (I'm afraid of behaviour changes between versions). I'll update the discussion. |
I would agree with your points if the setting was called |
I have updated the linked discussion. |
Clarified docs about this setting. There may be a confusion whether the setting means overall amount of connection attempts or amount after the initial unsuccessful attempt. Usually a retries amount option means the latter, but here it means the former. Decided to don't change behaviour or the setting name to provide perfect backward compatibility, but give meaningful error and clarify docs. See the discussion in [1]. [1]: #145 (comment) Fixes #83
Clarified docs about this setting. There may be a confusion whether the setting means overall amount of connection attempts or amount after the initial unsuccessful attempt. Usually a retries amount option means the latter, but here it means the former. Decided to don't change behaviour or the setting name to provide perfect backward compatibility, but give meaningful error and clarify docs. See the discussion in [1]. [1]: #145 (comment) Fixes #83
Clarified docs about this setting. There may be a confusion whether the setting means overall amount of connection attempts or amount after the initial unsuccessful attempt. Usually a retries amount option means the latter, but here it means the former. Decided to don't change behaviour or the setting name to provide perfect backward compatibility, but give meaningful error and clarify docs. See the discussion in [1]. [1]: #145 (comment) Fixes #83
outputs
The text was updated successfully, but these errors were encountered: