-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: changelog.md updates #6411
Merged
Totktonada
merged 2 commits into
master
from
Totktonada/fix-a-link-in-changelogs-md-notest
Sep 14, 2021
Merged
doc: changelog.md updates #6411
Totktonada
merged 2 commits into
master
from
Totktonada/fix-a-link-in-changelogs-md-notest
Sep 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Totktonada
commented
Sep 2, 2021
- Fixed a typo in a link anchor.
- Added an alternative process (to better highlight why we stick with our one).
igormunkin
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Totktonada, thanks for the changes! LGTM since they are trivial.
Side note: I believe we can fix errors and typos, when building the final version of the changelog at the moment git tag is set, but yes, our approach is more flexible and convenient (at least for me).
kyukhin
reviewed
Sep 3, 2021
Totktonada
force-pushed
the
Totktonada/fix-a-link-in-changelogs-md-notest
branch
from
September 8, 2021 23:41
f8793a1
to
708a5d6
Compare
|
kyukhin
suggested changes
Sep 9, 2021
Totktonada
force-pushed
the
Totktonada/fix-a-link-in-changelogs-md-notest
branch
from
September 12, 2021 14:11
708a5d6
to
f054b48
Compare
I think that our current process is better. But if someone will want to understand why we stick with it, it is good to have explicit cons and pros.
Totktonada
force-pushed
the
Totktonada/fix-a-link-in-changelogs-md-notest
branch
from
September 14, 2021 09:11
f054b48
to
70fdac3
Compare
kyukhin
approved these changes
Sep 14, 2021
Totktonada
deleted the
Totktonada/fix-a-link-in-changelogs-md-notest
branch
September 14, 2021 11:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.